Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

raise ParserError for unsupported datetime formats #483

Conversation

armando1793
Copy link

@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #483 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #483   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        3189   3199   +10     
  Branches      229    232    +3     
=====================================
+ Hits         3189   3199   +10
Impacted Files Coverage Δ
tests/parser_tests.py 100% <100%> (ø) ⬆️
arrow/parser.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33925e...1339553. Read the comment docs.

@jadchaar
Copy link
Member

jadchaar commented Jul 17, 2019

Hey @armando1793, thanks for the contribution, but we have implemented a more general and robust regular expression solution for detecting invalid formats. You can check out the upcoming changes outlined here: #612.

@jadchaar jadchaar closed this Jul 17, 2019
@armando1793
Copy link
Author

Oh sure no problem. Thanks for the update! I'll take a look at the changes

@jadchaar
Copy link
Member

Feel free to take on some new issues though :). We are trying to re-invigorate arrow's development and need all the help we can get! As part of that process though, we are cleaning up some old issues and PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants