Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add day_of_year in parser #481

Closed
wants to merge 1 commit into from

Conversation

aysonje
Copy link

@aysonje aysonje commented Nov 9, 2017

Resolves #396

@codecov-io
Copy link

codecov-io commented Nov 9, 2017

Codecov Report

Merging #481 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #481   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          14     14           
  Lines        3189   3226   +37     
  Branches      229    236    +7     
=====================================
+ Hits         3189   3226   +37
Impacted Files Coverage Δ
arrow/formatter.py 100% <100%> (ø) ⬆️
arrow/parser.py 100% <100%> (ø) ⬆️
tests/formatter_tests.py 100% <100%> (ø) ⬆️
tests/parser_tests.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b33925e...eea49da. Read the comment docs.

@systemcatch systemcatch self-requested a review December 28, 2018 19:59
@systemcatch
Copy link
Collaborator

Hey, sorry this has taken so long to be looked at. If we can fix the conflicts with master then I'd like to try and merge this in with a few changes. I'm not keen on having both DDD and j doing the same thing, better to just stick with DDD for consistency imo, %j can just be kept for working with the strptime class method.

We could also look at adding support for DDDD (zero padded version for day of year) but that can always be another PR.

@systemcatch
Copy link
Collaborator

Parsing for the DDD and DDDD tokens has been implemented in the 0.15.0 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Day of Year Support
3 participants