Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change span_range typehint to allow Arrow #1149

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

laundmo
Copy link

@laundmo laundmo commented Jan 18, 2023

Pull Request Checklist

Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:

  • 🧪 Added tests for changed code.
  • 🛠️ All tests pass when run locally (run tox or make test to find out!).
  • 🧹 All linting checks pass when run locally (run tox -e lint or make lint to find out!).
  • 📚 Updated documentation for changed code.
  • ⏩ Code is up-to-date with the master branch.

No tests were added as no behaviour was changed (only typehints)

Description of Changes

Changes the type hints of Arrow.span_range to correctly indicate it can also be called on Arrow objects.

To pass mypy, the type hints of fromdatetime also had to be changed to indicate it also works with Arrow objects.

Closes: #987

@codecov
Copy link

codecov bot commented Jan 28, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (522a65b) 100.00% compared to head (a13fa68) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #1149   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines         2326      2326           
  Branches       400       400           
=========================================
  Hits          2326      2326           
Files Coverage Δ
arrow/arrow.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add native support for Arrow objects in span_range
2 participants