Add fold kwarg for arrow.get #1139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nik-k11
commented
Oct 28, 2022
Comment on lines
-77
to
-78
| assert hasattr(before, "fold") | ||
| assert hasattr(after, "fold") |
There was a problem hiding this comment.
This basically checks for presence of the Arrow.fold property, seems unnecessary.
Codecov ReportBase: 100.00% // Head: 100.00% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #1139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 2319 2325 +6
Branches 492 495 +3
=========================================
+ Hits 2319 2325 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Thank you for taking the time to improve Arrow! Before submitting your pull request, please check all appropriate boxes:
toxormake testto find out!).tox -e lintormake lintto find out!).masterbranch.If you have any questions about your code changes or any of the points above, please submit your questions along with the pull request and we will try our best to help!
Description of Changes
foldkwarg forarrow.get.getattrsince Python 2.7/3.5 support is dropped.Arrow.__init__per this discussion.Also please note the
folddocumentation inArrowFactory.get. Basically, I only relay thefoldkwarg intoArrow.fromdatetimeandArrow.__init__calls.Doesn't seem like using
foldfor timestamps,nowcalls or dates makes sense. But maybe it should be passed. What do you think?Closes: #872