Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add native support for Arrow objects in span_range #987

Open
ParadoxShmaradox opened this issue Jun 9, 2021 · 0 comments · May be fixed by #1149
Open

Add native support for Arrow objects in span_range #987

ParadoxShmaradox opened this issue Jun 9, 2021 · 0 comments · May be fixed by #1149
Labels

Comments

@ParadoxShmaradox
Copy link

Issue Description

The span_range function typehint the start and end as datetime objects.

def span_range( cls, frame: _T_FRAMES, start: dt_datetime, end: dt_datetime, tz: Optional[TZ_EXPR] = None, limit: Optional[int] = None, bounds: _BOUNDS = "[)", exact: bool = False, ) -> Iterable[Tuple["Arrow", "Arrow"]]

It's will happily work with Arrow objects.

This works because the fromdatetime function will take an Arrow object and convert it again to an Arrow object.

I believe the correct usage it to natively support Arrow objects as input without explicitly converting an Arrow object to datetime just to be converted again internally.

@systemcatch systemcatch changed the title span_range usage with Arrow objects Add native support for Arrow objects in span_range Sep 7, 2021
@laundmo laundmo linked a pull request Jan 18, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant