Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(Either): correct error in getOrElse #2548

Merged
merged 1 commit into from Oct 24, 2021

Conversation

codymikol
Copy link
Contributor

this fixes the example of getOrElse to use a
lambda function rather than just passing a value.

Fixes N/A

this fixes the example of `getOrElse` to use a
lambda function rather than just passing a value.

Fixes N/A
@nomisRev
Copy link
Member

nomisRev commented Oct 8, 2021

@codymikol, thanks for these contributions!

If you're interested, you could also make these examples compile safe.
Which means we can check on CI if the examples compile, and they have the correct output.

By changing the code to ```kotlin:ank, and adding the imports.
Then you could also use assertions to replace // Result: 12.

I think kotest assertions are on the classpath where we run the examples as scripts on CI.

Copy link
Member

@i-walker i-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

@nomisRev nomisRev merged commit 24a71fc into arrow-kt:main Oct 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants