Change more Gradle config and GitHub Actions workflows #2544

JavierSegoviaCordoba · 2021-10-03T02:01:03Z

Migrate more files to kts
Use Version Catalogs in all projects
Rename some Gradle properties in multiple gradle.properties files
Change and improve GitHub Actions workflows

nomisRev · 2021-10-03T09:55:16Z

.github/workflows/publish.yml

+          echo "$(cat gradle.properties | grep projects.version | cut -d'=' -f2) MingwX64 deployed!"
+
+      - name: Stop Gradle daemons
+        run: ./gradlew --stop


This was to fix the cache issue? Is there any link you can reference? Curious about the technical details :p

I think it was a workaround in the issue filed in the Cache repo, this one actions/cache#454.

Not sure why, I guess the daemon blocks the access to those folders and then it fails, similar what you get in local when you run a lot of Gradle tasks over the same project.

Thanks for the update @JavierSegoviaCordoba!

nomisRev · 2021-10-03T09:55:51Z

arrow-libs/settings.gradle.kts

@@ -26,6 +26,12 @@ pluginManagement {
 }

 dependencyResolutionManagement {
+  versionCatalogs {


nomisRev

👏 👏 👏 amazing work @JavierSegoviaCordoba thank you!!

nomisRev · 2021-10-03T09:59:55Z

@JavierSegoviaCordoba looking at the Github Actions times, it looks like we can collapse the split between macos_and_ios and tv_and_watchos. I think all those targets will still be faster than ktlint & Dokka. The limit for free macos jobs is 5, so this would allow more PRs to run in parallel.

raulraja

thanks @JavierSegoviaCordoba , looks great!

- Migrate more files to `kts` - Use Version Catalogs in all projects - Rename some Gradle properties in multiple `gradle.properties` files - Change and improve GitHub Actions workflows

JavierSegoviaCordoba · 2021-10-03T11:24:38Z

@JavierSegoviaCordoba looking at the Github Actions times, it looks like we can collapse the split between macos_and_ios and tv_and_watchos. I think all those targets will still be faster than ktlint & Dokka. The limit for free macos jobs is 5, so this would allow more PRs to run in parallel.

Changed to run all apple targets in the same job

nomisRev reviewed Oct 3, 2021

View reviewed changes

arrow-libs/settings.gradle.kts

@@ -26,6 +26,12 @@ pluginManagement {

}

dependencyResolutionManagement {

versionCatalogs {

Copy link

Member

nomisRev Oct 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

nomisRev approved these changes Oct 3, 2021

View reviewed changes

nomisRev requested review from raulraja and a team October 3, 2021 09:57

raulraja approved these changes Oct 3, 2021

View reviewed changes

Change more Gradle config and GitHub Actions workflows

633e1aa

- Migrate more files to `kts` - Use Version Catalogs in all projects - Rename some Gradle properties in multiple `gradle.properties` files - Change and improve GitHub Actions workflows

JavierSegoviaCordoba force-pushed the add-gradle-config branch from 02c3eb0 to 633e1aa Compare October 3, 2021 11:24

nomisRev merged commit 9b9b7e2 into main Oct 3, 2021

nomisRev deleted the add-gradle-config branch October 3, 2021 12:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Change more Gradle config and GitHub Actions workflows #2544

Change more Gradle config and GitHub Actions workflows #2544

JavierSegoviaCordoba commented Oct 3, 2021

nomisRev Oct 3, 2021

JavierSegoviaCordoba Oct 3, 2021

nomisRev Oct 3, 2021

nomisRev Oct 3, 2021

nomisRev left a comment

nomisRev commented Oct 3, 2021 •

edited

raulraja left a comment

JavierSegoviaCordoba commented Oct 3, 2021

Change more Gradle config and GitHub Actions workflows #2544

Change more Gradle config and GitHub Actions workflows #2544

Conversation

JavierSegoviaCordoba commented Oct 3, 2021

nomisRev Oct 3, 2021

Choose a reason for hiding this comment

JavierSegoviaCordoba Oct 3, 2021

Choose a reason for hiding this comment

nomisRev Oct 3, 2021

Choose a reason for hiding this comment

nomisRev Oct 3, 2021

Choose a reason for hiding this comment

nomisRev left a comment

Choose a reason for hiding this comment

nomisRev commented Oct 3, 2021 • edited

raulraja left a comment

Choose a reason for hiding this comment

JavierSegoviaCordoba commented Oct 3, 2021

nomisRev commented Oct 3, 2021 •

edited