Add Arrow Gradle config #2543
Merged
Add Arrow Gradle config #2543
+687
−895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nomisRev
reviewed
Sep 30, 2021
There was a problem hiding this comment.
Looks awesome @JavierSegoviaCordoba 😍 I have a couple of questions, and I think perhaps there is some opportunity to remove some redundant config we had before.
...-libs/core/arrow-meta/arrow-meta-test-models/src/main/java/arrow/ap/objects/iso/IsoSealed.kt
Outdated
Show resolved
Hide resolved
JavierSegoviaCordoba
force-pushed
the
add-gradle-config
branch
from
139a7b8 to
3743b5b
Compare
nomisRev
reviewed
Sep 30, 2021
nomisRev
reviewed
Sep 30, 2021
arrow-libs/core/arrow-meta/arrow-meta-test-models/build.gradle.kts
Outdated
Show resolved
Hide resolved
JavierSegoviaCordoba
force-pushed
the
add-gradle-config
branch
5 times, most recently
from
b50cafb to
76f1a8d
Compare
JavierSegoviaCordoba
force-pushed
the
add-gradle-config
branch
from
01dd04d to
e5f4fd3
Compare
JavierSegoviaCordoba
force-pushed
the
add-gradle-config
branch
from
e5f4fd3 to
53bd6c4
Compare
nomisRev
reviewed
Oct 1, 2021
JavierSegoviaCordoba
force-pushed
the
add-gradle-config
branch
from
d9580e2 to
b033329
Compare
JavierSegoviaCordoba
force-pushed
the
add-gradle-config
branch
from
b033329 to
8e6daae
Compare
nomisRev
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It compiles, all tests are passing, and all publications to the maven local repository seem right.
Tasks: