move core to be mpp #20

i-walker · 2021-10-24T23:22:30Z

Status:
temporarily on hold

A fix for https://app.clickup.com/t/kt7qd2 has been addressed here, but we can improve it more in further iterations, adding validation steps before parsing the Uri

TODO:

implement js plattform specifc parts [IN PROGRESS: 97 % passed tests]
implement native platform specific parts

# Conflicts: # build.gradle.kts # core/build.gradle.kts

� Conflicts: � core/build.gradle.kts � core/src/commonMain/kotlin/arrow/endpoint/ArrowEndpoint.kt � core/src/commonMain/kotlin/arrow/endpoint/Endpoint.kt � core/src/commonMain/kotlin/arrow/endpoint/EndpointIO.kt � core/src/commonMain/kotlin/arrow/endpoint/EndpointInput.kt � core/src/commonMain/kotlin/arrow/endpoint/EndpointInterceptor.kt � core/src/commonMain/kotlin/arrow/endpoint/EndpointOutput.kt � core/src/commonMain/kotlin/arrow/endpoint/EndpointTransput.kt � core/src/commonMain/kotlin/arrow/endpoint/FieldName.kt � core/src/commonMain/kotlin/arrow/endpoint/Mapping.kt � core/src/commonMain/kotlin/arrow/endpoint/MethodSyntax.kt � core/src/commonMain/kotlin/arrow/endpoint/Params.kt � core/src/commonMain/kotlin/arrow/endpoint/client/RequestInfo.kt � core/src/commonMain/kotlin/arrow/endpoint/model/CodecFormat.kt � core/src/commonMain/kotlin/arrow/endpoint/model/Cookie.kt � core/src/commonMain/kotlin/arrow/endpoint/model/Header.kt � core/src/commonMain/kotlin/arrow/endpoint/model/MediaType.kt � core/src/commonMain/kotlin/arrow/endpoint/model/Method.kt � core/src/commonMain/kotlin/arrow/endpoint/model/QueryParams.kt � core/src/commonMain/kotlin/arrow/endpoint/model/Rfc2616.kt � core/src/commonMain/kotlin/arrow/endpoint/model/Rfc3986.kt � core/src/commonMain/kotlin/arrow/endpoint/model/StatusCode.kt � core/src/commonMain/kotlin/arrow/endpoint/server/ServerEndpoint.kt � core/src/commonMain/kotlin/arrow/endpoint/server/interpreter/DecodeBasicInputsResult.kt � core/src/commonMain/kotlin/arrow/endpoint/server/interpreter/InputValueResult.kt � core/src/commonMain/kotlin/arrow/endpoint/server/interpreter/OutputValues.kt � core/src/commonMain/kotlin/arrow/endpoint/server/interpreter/RequestBody.kt � core/src/commonMain/kotlin/arrow/endpoint/server/interpreter/ServerInterpreter.kt � core/src/jvmMain/kotlin/arrow/endpoint/ArrowEndpoint.kt � core/src/jvmMain/kotlin/arrow/endpoint/Endpoint.kt � core/src/jvmMain/kotlin/arrow/endpoint/EndpointIO.kt � core/src/jvmMain/kotlin/arrow/endpoint/EndpointInput.kt � core/src/jvmMain/kotlin/arrow/endpoint/EndpointInterceptor.kt � core/src/jvmMain/kotlin/arrow/endpoint/EndpointOutput.kt � core/src/jvmMain/kotlin/arrow/endpoint/EndpointTransput.kt � core/src/jvmMain/kotlin/arrow/endpoint/FieldName.kt � core/src/jvmMain/kotlin/arrow/endpoint/Mapping.kt � core/src/jvmMain/kotlin/arrow/endpoint/MethodSyntax.kt � core/src/jvmMain/kotlin/arrow/endpoint/Params.kt � core/src/jvmMain/kotlin/arrow/endpoint/client/RequestInfo.kt � core/src/jvmMain/kotlin/arrow/endpoint/model/CodecFormat.kt � core/src/jvmMain/kotlin/arrow/endpoint/model/Cookie.kt � core/src/jvmMain/kotlin/arrow/endpoint/model/Header.kt � core/src/jvmMain/kotlin/arrow/endpoint/model/MediaType.kt � core/src/jvmMain/kotlin/arrow/endpoint/model/Method.kt � core/src/jvmMain/kotlin/arrow/endpoint/model/QueryParams.kt � core/src/jvmMain/kotlin/arrow/endpoint/model/Rfc2616.kt � core/src/jvmMain/kotlin/arrow/endpoint/model/Rfc3986.kt � core/src/jvmMain/kotlin/arrow/endpoint/model/StatusCode.kt � core/src/jvmMain/kotlin/arrow/endpoint/server/ServerEndpoint.kt � core/src/jvmMain/kotlin/arrow/endpoint/server/interpreter/DecodeBasicInputsResult.kt � core/src/jvmMain/kotlin/arrow/endpoint/server/interpreter/InputValueResult.kt � core/src/jvmMain/kotlin/arrow/endpoint/server/interpreter/OutputValues.kt � core/src/jvmMain/kotlin/arrow/endpoint/server/interpreter/RequestBody.kt � core/src/jvmMain/kotlin/arrow/endpoint/server/interpreter/ServerInterpreter.kt � core/src/main/kotlin/arrow/endpoint/ArrowEndpoint.kt � core/src/main/kotlin/arrow/endpoint/Endpoint.kt � core/src/main/kotlin/arrow/endpoint/EndpointIO.kt � core/src/main/kotlin/arrow/endpoint/EndpointInput.kt � core/src/main/kotlin/arrow/endpoint/EndpointInterceptor.kt � core/src/main/kotlin/arrow/endpoint/EndpointOutput.kt � core/src/main/kotlin/arrow/endpoint/EndpointTransput.kt � core/src/main/kotlin/arrow/endpoint/FieldName.kt � core/src/main/kotlin/arrow/endpoint/Mapping.kt � core/src/main/kotlin/arrow/endpoint/MethodSyntax.kt � core/src/main/kotlin/arrow/endpoint/Params.kt � core/src/main/kotlin/arrow/endpoint/client/RequestInfo.kt � core/src/main/kotlin/arrow/endpoint/model/CodecFormat.kt � core/src/main/kotlin/arrow/endpoint/model/Cookie.kt � core/src/main/kotlin/arrow/endpoint/model/Header.kt � core/src/main/kotlin/arrow/endpoint/model/MediaType.kt � core/src/main/kotlin/arrow/endpoint/model/Method.kt � core/src/main/kotlin/arrow/endpoint/model/QueryParams.kt � core/src/main/kotlin/arrow/endpoint/model/Rfc2616.kt � core/src/main/kotlin/arrow/endpoint/model/Rfc3986.kt � core/src/main/kotlin/arrow/endpoint/model/StatusCode.kt � core/src/main/kotlin/arrow/endpoint/server/ServerEndpoint.kt � core/src/main/kotlin/arrow/endpoint/server/interpreter/DecodeBasicInputsResult.kt � core/src/main/kotlin/arrow/endpoint/server/interpreter/InputValueResult.kt � core/src/main/kotlin/arrow/endpoint/server/interpreter/OutputValues.kt � core/src/main/kotlin/arrow/endpoint/server/interpreter/RequestBody.kt � core/src/main/kotlin/arrow/endpoint/server/interpreter/ServerInterpreter.kt

# Conflicts: # build.gradle.kts # core/src/commonMain/kotlin/arrow/endpoint/model/Rfc3986.kt # core/src/commonMain/kotlin/arrow/endpoint/model/Uri.kt # core/src/commonMain/kotlin/arrow/endpoint/model/UriCompatibility.kt # core/src/jvmMain/kotlin/arrow/endpoint/model/Uri.kt

# Conflicts: # core/build.gradle.kts

# Conflicts: # build.gradle.kts # core/build.gradle.kts

# Conflicts: # core/src/commonMain/kotlin/arrow/endpoint/model/Uri.kt # core/src/jvmMain/kotlin/arrow/endpoint/model/UriUtils.kt

# Conflicts: # build.gradle.kts # clients/ktor-client/src/main/kotlin/arrow/endpoint/ktor/client/KtorClientInterpreter.kt # core/build.gradle.kts # core/src/commonMain/kotlin/arrow/endpoint/ArrowEndpoint.kt # core/src/commonMain/kotlin/arrow/endpoint/model/Method.kt # core/src/commonMain/kotlin/arrow/endpoint/model/QueryParams.kt # core/src/commonMain/kotlin/arrow/endpoint/model/RequestMetadata.kt # core/src/commonMain/kotlin/arrow/endpoint/model/Rfc3986.kt # core/src/commonMain/kotlin/arrow/endpoint/model/Uri.kt # core/src/commonMain/kotlin/arrow/endpoint/predef.kt # core/src/jvmMain/kotlin/arrow/endpoint/CodecUtils.kt # core/src/jvmMain/kotlin/arrow/endpoint/SchemaUtils.kt # core/src/jvmMain/kotlin/arrow/endpoint/model/UriUtils.kt # servers/ktor-server/src/main/kotlin/arrow/endpoint/ktor/server/KtorHttpServerInterpreter.kt

nomisRev

Making good progress. Nice!

core/src/commonMain/kotlin/arrow/endpoint/model/QueryParams.kt

build.gradle.kts

core/build.gradle.kts

core/src/jsMain/kotlin/arrow/endpoint/predef.kt

nomisRev · 2022-01-24T16:10:40Z

core/src/jvmMain/kotlin/arrow/endpoint/CodecUtils.kt

+import java.util.Date
+
+public val Codec.Companion.uuid: Codec<String, UUID, CodecFormat.TextPlain>
+  get() = stringCodec(Schema.uuid, UUID::fromString)


Cannot be = without get(), right? Can we cache the instances?

I haven't looked into Caching, yet ☺️

i-walker · 2022-01-24T16:16:42Z

Don't fear the 2k changes, most of it is just the yarn file for KotlinJS

nomisRev · 2022-01-24T16:17:35Z

Thanks for taking this on @i-walker 💪

# Conflicts: # core/build.gradle.kts # core/src/main/kotlin/arrow/endpoint/model/Uri.kt

nomisRev · 2022-01-28T08:43:40Z

core/src/commonTest/kotlin/arrow/endpoint/model/UriTest.kt

+      parseToUri("http://abcd").fold(
+        { fail("this should work") },


This can all become shoudBeRight(), no?

Correct, there are also other places where this fix applies, but I am focusing on getting the other platform tests to compile first.

…lencodedData

i-walker · 2022-01-28T22:51:18Z

small Update:
I am reverting from the approach to have platform-specific encoders/ decoders for the Uri and Query Segments, instead going to write those algorithms in kotlin. I found some inconsistencies between libraries between native, js, and jvm. Ktor solves this similarly

progress

88559c0

i-walker mentioned this pull request Oct 24, 2021

Update to Arrow 1.0.0 and make MPP #56 #3

Open

i-walker added 24 commits November 1, 2021 12:18

progress

b8e1bac

Merge remote-tracking branch 'origin/main' into mpp-core

b790c85

# Conflicts: # build.gradle.kts # core/build.gradle.kts

progress

be040bb

progress

6115b5f

progress

8484f2b

fixed core mpp migration, except Uri

e462f9f

further migrations

f7f7adb

clena up

cc72b47

progress

5e8f52a

# Conflicts: # build.gradle.kts # core/src/commonMain/kotlin/arrow/endpoint/model/Rfc3986.kt # core/src/commonMain/kotlin/arrow/endpoint/model/Uri.kt # core/src/commonMain/kotlin/arrow/endpoint/model/UriCompatibility.kt # core/src/jvmMain/kotlin/arrow/endpoint/model/Uri.kt

progress

23dedbf

# Conflicts: # core/build.gradle.kts

fixed core mpp migration, except Uri

8445222

# Conflicts: # build.gradle.kts # core/build.gradle.kts

further migrations

e336eec

# Conflicts: # core/src/commonMain/kotlin/arrow/endpoint/model/Uri.kt # core/src/jvmMain/kotlin/arrow/endpoint/model/UriUtils.kt

Merge remote-tracking branch 'origin/main' into mpp-core

5de3b2a

remove ByteBuffer and inputstream references

7d1f60b

clean up

7fdc953

clean up

f7c9c50

add Optin

221759f

add JvmInline

e3bee82

clean up

64cb6a3

clean up

aa20dc2

clean up

a81f90e

add yarn lock

07bf507

nomisRev reviewed Jan 24, 2022

View reviewed changes

small progress in uri parse

aebce42

i-walker added 13 commits January 24, 2022 20:54

move to stdlibcommon

f43ef59

move to stdlibcommon

982a535

add mpp decoder

5b3bfa2

reorg and remove companion object of Uri

a78bd19

implement new parser, still need to authority

bc2ba9f

fix remaining errors

e343095

Merge remote-tracking branch 'origin/main' into mpp-core

b9a2e0b

# Conflicts: # core/build.gradle.kts # core/src/main/kotlin/arrow/endpoint/model/Uri.kt

mask testts

7c5c3f4

lowercase host nd unmask all tests

c7b7722

rm kotest dependency

e4fbc9d

implement js part

c5dae11

clean up and add js related git ignore

dd31440

resolve missing dependiences, also

564ec74

nomisRev reviewed Jan 28, 2022

View reviewed changes

i-walker added 2 commits January 28, 2022 11:43

resolve Schema tests to be jvm only and compile and run jsTest

b618978

fix js tests, besides a few encoding tests and change signature of Ur…

ca63cf2

…lencodedData

make UrlencodedData mpp and simplify encodeQuery from Uricompatibily

0a76fb3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

move core to be mpp #20

move core to be mpp #20

i-walker commented Oct 24, 2021 •

edited

nomisRev left a comment

nomisRev Jan 24, 2022

i-walker Jan 24, 2022

i-walker Jan 24, 2022

i-walker commented Jan 24, 2022

nomisRev commented Jan 24, 2022

nomisRev Jan 28, 2022

i-walker Jan 28, 2022 •

edited

i-walker commented Jan 28, 2022 •

edited

		parseToUri("http://abcd").fold(
		{ fail("this should work") },

move core to be mpp #20

Are you sure you want to change the base?

move core to be mpp #20

Conversation

i-walker commented Oct 24, 2021 • edited

nomisRev left a comment

Choose a reason for hiding this comment

nomisRev Jan 24, 2022

Choose a reason for hiding this comment

i-walker Jan 24, 2022

Choose a reason for hiding this comment

i-walker Jan 24, 2022

Choose a reason for hiding this comment

i-walker commented Jan 24, 2022

nomisRev commented Jan 24, 2022

nomisRev Jan 28, 2022

Choose a reason for hiding this comment

i-walker Jan 28, 2022 • edited

Choose a reason for hiding this comment

i-walker commented Jan 28, 2022 • edited

i-walker commented Oct 24, 2021 •

edited

i-walker Jan 28, 2022 •

edited

i-walker commented Jan 28, 2022 •

edited