Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARQ-1657 Consistent usage of @OperateOnDeployment #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kpiwko
Copy link
Member

@kpiwko kpiwko commented Feb 25, 2014

No description provided.

@aslakknutsen
Copy link
Member

Even tho OperatesOnDeploymentAwareProvider is a impl detail, I do believe it is being used by some extensions/containers.

I can allow changes to javadocs, but not class signatures at this time.

@kpiwko
Copy link
Member Author

kpiwko commented Feb 25, 2014

So, I can either:

1/ Modify the commit to contain javadoc changes only
2/ Create a wrapper to stay backwards compatible, e.g. OperatesOnDeploymentProvider extends OperateOnDeployment provider, were OperatesOnDeploymentProvider is @deprecated

Which option do you prefer?

@aslakknutsen
Copy link
Member

Simply adding a class OperatesOnDeploymentAwareProvider extends OperateOnDeployment.. should work. No problem updating the ResourceProviers in Core to point to OperateOnDeployment...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants