Let ark-ff specify the same num-bigint
version as the rest of the repos
#317
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is related to #316 but is not expected to be a solution.
There is a pending "unstable feature" in Rust 1.56 beta that requires
num-bigint
to be bumped up to0.4.2
or higher to be able to compile.My local test seems to show that the compiler would always retrieve the
0.4.2
version (since arkwork-rs never uses Cargo.lock). So this seems to be an issue for downstream applications to handle.Nevertheless, we can improve the current code: only the
algebra
andr1cs-std
repos usenum-bigint
, andark-ff
is the only one that is specifying0.4.0
, while the rest are all using0.4
.This PR changes what
ark-ff
specifies in the Cargo.toml to 0.4, thereby keeping it consistent with the rest.This does not closes #316. We will see whether more changes will be needed due to potential Rust changes.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Files changed
in the Github PR explorerN/A:
Pending
section inCHANGELOG.md