Issue checkstyle#12441: Resolve Pitest suppression for RightCurlyCheck

arinmodi · Nov 23, 2022 · e5b77a6 · e5b77a6
1 parent 55e09e5
commit e5b77a6
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 9 deletions.
diff --git a/.ci/pitest-suppressions/pitest-blocks-suppressions.xml b/.ci/pitest-suppressions/pitest-blocks-suppressions.xml
@@ -135,15 +135,6 @@
     <lineContent>switch (ast.getType()) {</lineContent>
   </mutation>
 
-  <mutation unstable="false">
-    <sourceFile>RightCurlyCheck.java</sourceFile>
-    <mutatedClass>com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck$Details</mutatedClass>
-    <mutatedMethod>getDetailsForIfElse</mutatedMethod>
-    <mutator>org.pitest.mutationtest.engine.gregor.mutators.NonVoidMethodCallMutator</mutator>
-    <description>removed call to com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheck$Details::getNextToken</description>
-    <lineContent>nextToken = getNextToken(ast);</lineContent>
-  </mutation>
-
   <mutation unstable="false">
     <sourceFile>RightCurlyCheck.java</sourceFile>
     <mutatedClass>com.puppycrawl.tools.checkstyle.checks.blocks.RightCurlyCheck$Details</mutatedClass>

diff --git a/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheckTest.java b/src/test/java/com/puppycrawl/tools/checkstyle/checks/blocks/RightCurlyCheckTest.java
@@ -105,6 +105,7 @@ public void testAlone() throws Exception {
             "184:9: " + getCheckMessage(MSG_KEY_LINE_ALONE, "}", 9),
             "189:9: " + getCheckMessage(MSG_KEY_LINE_ALONE, "}", 9),
             "190:53: " + getCheckMessage(MSG_KEY_LINE_ALONE, "}", 53),
+            "221:12: " + getCheckMessage(MSG_KEY_LINE_ALONE, "}", 12),
         };
         verifyWithInlineConfigParser(
                 getPath("InputRightCurlyLeftTestAlone.java"), expected);

diff --git a/...om/puppycrawl/tools/checkstyle/checks/blocks/rightcurly/InputRightCurlyLeftTestAlone.java b/...om/puppycrawl/tools/checkstyle/checks/blocks/rightcurly/InputRightCurlyLeftTestAlone.java
@@ -211,4 +211,15 @@ interface Interface3 {
         interface Interface4 {
             void myMethod();
         }} // ok
+
+    public void test() {
+       int id = 0;
+       switch (id) {
+           case 0: break;
+           case 1: if (1 == 0) {
+               break;
+           }; // violation ''}' at column 12 should be alone on a line.'
+           case 2: break;
+       }
+    }
 }