Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump Kubernetes clients to 1.29.2 #566

Merged
merged 4 commits into from
May 7, 2024

Conversation

sivchari
Copy link
Contributor

@sivchari sivchari commented Feb 28, 2024

This PR aims to updating Kubernetes version to 1.29.1

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 54.83871% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 55.25%. Comparing base (5fd9f44) to head (99b2b78).
Report is 3 commits behind head on master.

❗ Current head 99b2b78 differs from pull request most recent head d086c31. Consider uploading reports for the commit d086c31 to get more accurate results

Files Patch % Lines
pkg/utils/kube/resource_ops.go 0.00% 11 Missing ⚠️
pkg/sync/sync_context.go 88.23% 2 Missing ⚠️
pkg/utils/kube/kube.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #566      +/-   ##
==========================================
+ Coverage   54.71%   55.25%   +0.54%     
==========================================
  Files          41       41              
  Lines        4834     4821      -13     
==========================================
+ Hits         2645     2664      +19     
+ Misses       1977     1945      -32     
  Partials      212      212              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sivchari sivchari changed the title update k8s libs Bump Kubernetes 1.29.1 Feb 29, 2024
@sivchari sivchari changed the title Bump Kubernetes 1.29.1 Bump Kubernetes 1.29.2 Mar 12, 2024
Copy link

sonarcloud bot commented Mar 12, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sivchari
Copy link
Contributor Author

sivchari commented Apr 5, 2024

Hi @leoluz. Could you review it ? Thanks.

@sivchari
Copy link
Contributor Author

Hi, @pasha-codefresh . Could you review this PR ? Thanks.

@crenshaw-dev
Copy link
Collaborator

@sivchari are you still up for working on this? I have some time to help.

@sivchari
Copy link
Contributor Author

Hi, @crenshaw-dev

I've finished it, so could you check these changes ?

@crenshaw-dev
Copy link
Collaborator

@sivchari took a quick glance through, and it's looking good. Would you mind opening an Argo CD PR pointing at your gitops-engine fork so we can run those tests as well? Here's an example of how that looks: https://github.com/argoproj/argo-cd/pull/16967/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R296

@sivchari
Copy link
Contributor Author

sivchari commented May 1, 2024

Hi @crenshaw-dev
I'm sorry that I was late.
Thank you for watching my changes.

I've already opened the PR in ArgoCD. The following link is it and the only thing that I should do is to pass the CI.
So, if this PR is ready to be merged, I'd like to merge this PR into gitops-engine.
argoproj/argo-cd#17491

Thanks.

Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Signed-off-by: sivchari <shibuuuu5@gmail.com>
Copy link

sonarcloud bot commented May 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@blakepettersson blakepettersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crenshaw-dev crenshaw-dev changed the title Bump Kubernetes 1.29.2 chore: Bump Kubernetes clients to 1.29.2 May 7, 2024
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @sivchari!

@crenshaw-dev crenshaw-dev merged commit 86a3688 into argoproj:master May 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants