fix: handle nil ParseableType from GVKParser (#574)

* fix: handle nil ParseableType from GVKParser Signed-off-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com> * address review comments Signed-off-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com> --------- Signed-off-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
argoproj · May 9, 2024 · 0aecd43 · 0aecd43
1 parent 86a3688
commit 0aecd43
Showing 1 changed file with 7 additions and 0 deletions.
diff --git a/pkg/diff/diff.go b/pkg/diff/diff.go
@@ -208,6 +208,10 @@ func removeWebhookMutation(predictedLive, live *unstructured.Unstructured, gvkPa
 	}
 	gvk := predictedLive.GetObjectKind().GroupVersionKind()
 	pt := gvkParser.Type(gvk)
+	if pt == nil {
+		return nil, fmt.Errorf("unable to resolve parseableType for GroupVersionKind: %s", gvk)
+	}
+
 	typedPredictedLive, err := pt.FromUnstructured(predictedLive.Object)
 	if err != nil {
 		return nil, fmt.Errorf("error converting predicted live state from unstructured to %s: %w", gvk, err)
@@ -316,6 +320,9 @@ func structuredMergeDiff(p *SMDParams) (*DiffResult, error) {
 
 	gvk := p.config.GetObjectKind().GroupVersionKind()
 	pt := gescheme.ResolveParseableType(gvk, p.gvkParser)
+	if pt == nil {
+		return nil, fmt.Errorf("unable to resolve parseableType for GroupVersionKind: %s", gvk)
+	}
 
 	// Build typed value from live and config unstructures
 	tvLive, err := pt.FromUnstructured(p.live.Object)