Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default initialisation markNodePhase #9902

Merged
merged 2 commits into from Nov 9, 2022
Merged

fix: default initialisation markNodePhase #9902

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7644f14
fix: default initialisation markNodePhase
isubasinghe Oct 24, 2022
030fd53
Merge branch 'master' into no-panic-controller
sarabala1979 Nov 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion workflow/controller/operator.go
View file
Open in desktop
Expand Up @@ -2309,7 +2309,8 @@ func (woc *wfOperationCtx) initializeNode(nodeName string, nodeType wfv1.NodeTyp
func (woc *wfOperationCtx) markNodePhase(nodeName string, phase wfv1.NodePhase, message ...string) *wfv1.NodeStatus {
node := woc.wf.GetNodeByName(nodeName)
if node == nil {
panic(fmt.Sprintf("workflow '%s' node '%s' uninitialized when marking as %v: %s", woc.wf.Name, nodeName, phase, message))
woc.log.Warningf("workflow '%s' node '%s' uninitialized when marking as %v: %s", woc.wf.Name, nodeName, phase, message)
node = &wfv1.NodeStatus{}
}
if node.Phase != phase {
if node.Phase.Fulfilled() {
Expand Down