fix: Apply execution control to taskset nodes that are not part of exit handler and only delete agent pod if exists. #13016
+41
−31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 9, 2024 12:06
Signed-off-by: oninowang <oninowang@tencent.com>
Signed-off-by: oninowang <oninowang@tencent.com>
jswxstw
force-pushed
the
fix-taskset-nodes-with-agent-pod
branch
from
1399849
to
6cba1c9
Compare
tooptoop4
approved these changes
May 12, 2024
|
📦 |
4 tasks
Signed-off-by: jswxstw <jswxstw@gmail.com>
jswxstw
force-pushed
the
fix-taskset-nodes-with-agent-pod
branch
from
99f79a7
to
56b8628
Compare
Signed-off-by: jswxstw <jswxstw@gmail.com>
jswxstw
force-pushed
the
fix-taskset-nodes-with-agent-pod
branch
from
5d5c40c
to
21de6e7
Compare
jswxstw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12659
Fixes #13060
Motivation
Modifications
Modification 1
Execution control has been applied to the nodes with created pods after pod reconciliation. However, pending and suspended nodes do not have created pods, and taskset nodes use the agent pod. Mark these nodes failed when shutting down or exceeding deadline since pod reconciliation does not take effect on them.
Modification 2
Agent pod will only be created when taskset nodes exist, so do not delete it if it does not exist.
Modification 3
Skip execution control for exit nodes.
Verification