ci(deps): remove auto yarn-deduplicate on dependabot PRs
#12892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- reverts 568941e et al - ultimately, it would produce PRs that would not be mergeable as checks would not run on commits `push`ed via GH Actions - so it was fundamentally unworkable and hadn't been tested properly (note the missing "Verification" in the PR) - I do not know a good solution or workaround to this, but as it doesn't work, it should be removed - If we find something workable in the future, it can be added then once it's had extensive testing Signed-off-by: Anton Gilgur <agilgur5@gmail.com>
agilgur5
added
area/build
terrytangyuan
approved these changes
Apr 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #12234, per my comments in #12234 (comment) as well as testing in my fork agilgur5#3 (comment)
Motivation
ultimately, it would produce PRs that would not be mergeable as checks do not run on commits
pushed via GH ActionsI do not know a good solution or workaround to this, but as it doesn't work, it should be removed
Modifications
Remove the
yarn.lockdeduplication step inci-build.yaml's UI GHA jobVerification
It was working before #12234
Notes to Reviewers
Dependabot PRs with duplicate deps would fail to pass CI before #12234. This will happen again and those will need manual fixing. There's currently no workaround I know of if #12234 is fundamentally not doable.
That being said, since #12487, this should happen significantly less often, as only security updates are done, which are often only patch bumps that don't create duplicate deps.