New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Fixes git over azure devops Fixes #11705 #12598
base: main
Are you sure you want to change the base?
Conversation
Hey @clkamp , the CI is failing due to some flaky tests that were already fixed and merged to master, can you please merge them? |
cf3f23a
to
6d0a832
Compare
@agilgur5 Could you review and possibly merge this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry I've been passing a kidney stone the past month per my status (think I'm finally in the clear now, although the doctors aren't 100% sure...) among other things.
I left a comment in-line with some suggestions. Ideally we should limit this to Azure DevOps repos and only set it per request as well.
Could you also add a unit test for this?
Signed-off-by: Christian Lütke Stetzkamp <cls@tessitura.io>
Thanks for your review and sorry for my late reply. |
No, as I wrote before, this can cause issues and unexpected behavior for other providers.
You can check the URL in You also missed these two other parts from my previous review comment:
|
Fixes #11705
Verification
Tested it in a local dev environment, the fix is the one suggested in #11705 (comment)