feat: Display title and description in archived view #10796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmeridth
force-pushed
the
jm/title-and-description-annotations-in-archive-view
branch
3 times, most recently
from
e193bbd
to
e2a3416
Compare
|
Converting to draft because this isn't working yet. The archive workflow service does not have much in regards to annotations. UI is unchanged until the annotation can get to the new react component. Screen shot also once I get this working locally. Going to look at adding a test also. |
jmeridth
force-pushed
the
jm/title-and-description-annotations-in-archive-view
branch
from
e2a3416
to
94dbaf6
Compare
Already working in normal workflow view via argoproj#9805 - create shared react component for workflow row name to dry up usage of this code in both normal and archive workflow lists - add documentation regarding title and description annotations Signed-off-by: jmeridth <jmeridth@gmail.com>
jmeridth
force-pushed
the
jm/title-and-description-annotations-in-archive-view
branch
from
94dbaf6
to
e9cabe3
Compare
|
archived workflows api doesn't allow for additional fields. This is gonna be interesting. |
|
This will be affected by #10781 |
|
This will be impacted by #11121 |
|
@terrytangyuan 👍 yeah. I'm very excited about your changes. They will give the user a better experience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Already working in normal workflow view via #9805
Screenshot coming soon
Fixes #10771