Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use git binary in argoexec #10220

Closed
wants to merge 1 commit into from
Closed

Conversation

rohankmr414
Copy link
Member

Signed-off-by: Rohan Kumar rohan@pipekit.io

Fixes #10091

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Rohan Kumar <rohan@pipekit.io>
@rohankmr414 rohankmr414 marked this pull request as ready for review December 12, 2022 22:20
@rohankmr414 rohankmr414 marked this pull request as draft December 12, 2022 22:22
@stale
Copy link

stale bot commented Dec 31, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@stale stale bot added the problem/stale This has not had a response in some time label Dec 31, 2022
@stale
Copy link

stale bot commented Jan 8, 2023

This issue has been closed due to inactivity. Feel free to re-open if you still encounter this issue.

@stale stale bot closed this Jan 8, 2023
@JPZ13
Copy link
Member

JPZ13 commented Jan 12, 2023

@rohankmr414 Do we want to re-open this one?

@rohankmr414 rohankmr414 deleted the 10091 branch March 28, 2023 09:33
@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/artifacts S3/GCP/OSS/Git/HDFS etc labels Nov 5, 2023
@agilgur5
Copy link
Member

agilgur5 commented Nov 5, 2023

It looks like this was picked up in #10763, which was dropped in favor of #11149 as go-git is back in maintenance

@agilgur5 agilgur5 added solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) and removed problem/stale This has not had a response in some time labels Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc go Pull requests that update Go dependencies solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

move away from go-git
3 participants