Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Preserve symlinks in untar. Fixes #9948 #9949

Merged
merged 2 commits into from Nov 2, 2022

Conversation

swhite24
Copy link
Contributor

@swhite24 swhite24 commented Nov 2, 2022

Fixes #9948

Tested workflow provided in #9948 locally and observe symlinks being preserved when consuming artifact. Step output:

create-artifact

time="2022-11-02T20:10:11.208Z" level=info msg="capturing logs" argo=true
total 12
drwxrwxrwx    2 root     root          4096 Nov  2 20:10 .
drwxr-xr-x    3 root     root          4096 Nov  2 20:10 ..
-rw-rw-rw-    1 root     root             6 Nov  2 20:10 hello.txt
lrwxrwxrwx    1 root     root            16 Nov  2 20:10 link.txt -> output/hello.txt
time="2022-11-02T20:10:12.216Z" level=info msg="sub-process exited" argo=true error="<nil>"
time="2022-11-02T20:10:12.216Z" level=info msg="/app/output -> /var/run/argo/outputs/artifacts/app/output.tgz" argo=true
time="2022-11-02T20:10:12.216Z" level=info msg="Taring /app/output"
time="2022-11-02T20:10:12.216Z" level=debug msg="writing output"
time="2022-11-02T20:10:12.218Z" level=debug msg="writing output/hello.txt"
time="2022-11-02T20:10:12.218Z" level=debug msg="writing output/link.txt"
time="2022-11-02T20:10:12.218Z" level=info msg="archived 3 files/dirs in /app/output"

consume-artifact

time="2022-11-02T20:10:18.213Z" level=info msg="capturing logs" argo=true
total 12
drwx------    2 root     root          4096 Nov  2 20:10 .
drwxr-xr-x    3 root     root          4096 Nov  2 20:10 ..
-rw-rw-rw-    1 root     root             6 Nov  2 20:10 hello.txt
lrwxrwxrwx    1 root     root            16 Nov  2 20:10 link.txt -> output/hello.txt
time="2022-11-02T20:10:19.224Z" level=info msg="sub-process exited" argo=true error="<nil>"

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Steven White <swhitewvu24@gmail.com>
Signed-off-by: Steven White <swhitewvu24@gmail.com>
@swhite24 swhite24 marked this pull request as ready for review November 2, 2022 20:01
Copy link
Member

@terrytangyuan terrytangyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@terrytangyuan terrytangyuan changed the title Fixes #9948 - preserve symlinks in untar fix: Preserve symlinks in untar. Fixes #9948 Nov 2, 2022
@terrytangyuan terrytangyuan merged commit 4f1451e into argoproj:master Nov 2, 2022
juchaosong pushed a commit to juchaosong/argo-workflows that referenced this pull request Nov 3, 2022
Signed-off-by: Steven White <swhitewvu24@gmail.com>
Signed-off-by: juchao <juchao@coscene.io>
@agilgur5 agilgur5 added the area/artifacts S3/GCP/OSS/Git/HDFS etc label Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

symlink not preserved in tar input artifacts
3 participants