test: add test case for symlinks; update testdata

Signed-off-by: Steven White <swhitewvu24@gmail.com>
argoproj · Nov 2, 2022 · cd2ce01 · cd2ce01
1 parent 6b2178c
commit cd2ce01
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/workflow/executor/executor_test.go b/workflow/executor/executor_test.go
@@ -277,18 +277,30 @@ func TestUnzip(t *testing.T) {
 
 func TestUntar(t *testing.T) {
 	tarPath := "testdata/file.tar.gz"
-	destPath := "testdata/untarredFile"
+	destPath := "testdata/untarredDir"
+	filePath := "testdata/untarredDir/file"
+	linkPath := "testdata/untarredDir/link"
 
 	// test
 	err := untar(tarPath, destPath)
 	assert.NoError(t, err)
 
-	// check untarred file
+	// check untarred contents
 	fileInfo, err := os.Stat(destPath)
 	assert.NoError(t, err)
+	assert.True(t, fileInfo.Mode().IsDir())
+	fileInfo, err = os.Stat(filePath)
+	assert.NoError(t, err)
+	assert.True(t, fileInfo.Mode().IsRegular())
+	fileInfo, err = os.Stat(linkPath)
+	assert.NoError(t, err)
 	assert.True(t, fileInfo.Mode().IsRegular())
 
 	// cleanup
+	err = os.Remove(linkPath)
+	assert.NoError(t, err)
+	err = os.Remove(filePath)
+	assert.NoError(t, err)
 	err = os.Remove(destPath)
 	assert.NoError(t, err)
 }

diff --git a/workflow/executor/testdata/file.tar.gz b/workflow/executor/testdata/file.tar.gz
diff --git a/workflow/executor/testdata/link b/workflow/executor/testdata/link
@@ -0,0 +1 @@
+file