Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: default initialisation markNodePhase #9902

Merged
merged 2 commits into from Nov 9, 2022

Conversation

isubasinghe
Copy link
Member

@isubasinghe isubasinghe commented Oct 24, 2022

Signed-off-by: Isitha Subasinghe isitha@pipekit.io

Fixes #8972 uses the suggested solution here. I was not able to replicate the issue.

Please do not open a pull request until you have checked ALL of these:

  • Create the PR as draft .
  • Run make pre-commit -B to fix codegen and lint problems.
  • Sign-off your commits (otherwise the DCO check will fail).
  • Use a conventional commit message (otherwise the commit message check will fail).
  • "Fixes #" is in both the PR title (for release notes) and this description (to automatically link and close the issue).
  • [] Add unit or e2e tests. Say how you tested your changes. If you changed the UI, attach screenshots.
  • Github checks are green.
  • Once required tests have passed, mark your PR "Ready for review".

If changes were requested, and you've made them, dismiss the review to get it reviewed again.

Signed-off-by: Isitha Subasinghe <isitha@pipekit.io>
@caelan-io
Copy link
Member

@sarabala1979 I know we spoke about this yesterday. I simply wanted to call out that @isubasinghe changed the exact line of code that Alex suggested to change in his comment on this issue here. Can you please clarify where you'd suggest a change if not this line? Thanks!

@alexec
Copy link
Contributor

alexec commented Nov 7, 2022

This looks correct to me, yet. maybe Bala has a point.

Copy link
Member

@sarabala1979 sarabala1979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@sarabala1979 sarabala1979 enabled auto-merge (squash) November 9, 2022 16:23
@sarabala1979 sarabala1979 merged commit 1487bbc into argoproj:master Nov 9, 2022
@isubasinghe isubasinghe deleted the no-panic-controller branch November 9, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflow controller panics when stopping a workflow that has an Lifecycle-Hook with a plugin
5 participants