Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git artifacts: 'reference delta not found' clone problem #10225

Closed
2 of 3 tasks
ghost opened this issue Dec 13, 2022 · 6 comments · Fixed by argoproj-labs/go-git#7 or #10351
Closed
2 of 3 tasks

Git artifacts: 'reference delta not found' clone problem #10225

ghost opened this issue Dec 13, 2022 · 6 comments · Fixed by argoproj-labs/go-git#7 or #10351
Assignees
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc go Pull requests that update Go dependencies P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important type/bug type/dependencies PRs and issues specific to updating dependencies

Comments

@ghost
Copy link

ghost commented Dec 13, 2022

Pre-requisites

  • I have double-checked my configuration
  • I can confirm the issues exists when I tested with :latest
  • I'd like to contribute the fix myself (see contributing guide)

What happened/what you expected to happen?

Looks like the library 'go-git' that you are using for cloning git repositories has a problem "reference delta not found" on the git.PlainClone function.

Screenshot 2022-12-13 at 10 42 39

https://github.com/go-git/go-git/issues?q=is%3Aissue+reference+delta+not+found

Looks like in the latest version the problem is fixed. I think that a version update on your side will fix the problem.
Thank you!

Version

latest

Paste a small workflow that reproduces the issue. We must be able to run the workflow; don't enter a workflows that uses private images.

artifacts:
          - name: repo
            path: /src
            git:
              repo: "{{workflow.parameters.repo}}"
              revision: "{{workflow.parameters.revision}}"
              disableSubmodules: true
              usernameSecret:
                name: "{{workflow.parameters.secretName}}"
                key: username
              passwordSecret:
                name: "{{workflow.parameters.secretName}}"
                key: password

Logs from the workflow controller

kubectl logs -n argo deploy/workflow-controller | grep ${workflow}

ERRO[2022-12-13T10:08:07.481Z] container "main" in pod "create-flz2c-retrieve-changed-markdown-files-4256658970" is terminated  namespace=argo podName=create-flz2c-retrieve-changed-markdown-files-4256658970 workflow=create-flz2c

Logs from in your workflow's wait container

There are no logs
@ghost ghost added the type/bug label Dec 13, 2022
@sarabala1979 sarabala1979 added P1 High priority. All bugs with >=5 thumbs up that aren’t P0, plus: Any other bugs deemed high priority P3 Low priority and removed P1 High priority. All bugs with >=5 thumbs up that aren’t P0, plus: Any other bugs deemed high priority labels Dec 15, 2022
@rohankmr414 rohankmr414 self-assigned this Dec 18, 2022
@stale
Copy link

stale bot commented Jan 8, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If this is a mentoring request, please provide an update here. Thank you for your contributions.

@ivanspasov99
Copy link

Experiencing the same problem

@sarabala1979 sarabala1979 added P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important and removed P3 Low priority labels Jan 13, 2023
rohankmr414 added a commit to rohankmr414/argo-workflows that referenced this issue Jan 14, 2023
Signed-off-by: Rohan Kumar <rohan@pipekit.io>
sarabala1979 pushed a commit that referenced this issue Jan 14, 2023
Signed-off-by: Rohan Kumar <rohan@pipekit.io>
reddymh pushed a commit to reddymh/argo-workflows that referenced this issue Jan 31, 2023
…oproj#10351)

Signed-off-by: Rohan Kumar <rohan@pipekit.io>
Signed-off-by: Rajshekar Reddy <reddymh@gmail.com>
@lvijnck
Copy link

lvijnck commented Feb 6, 2023

I think this issue is still persisting, got it with the latest version, i.e., 3.4.4

@ghost
Copy link
Author

ghost commented Feb 6, 2023

I think this issue is still persisting, got it with the latest version, i.e., 3.4.4

There has not been a new release since the fix, i.e. it is not fixed in the 3.4.4 release, maybe in 3.4.5 (or what will be the next release version).
https://github.com/argoproj/argo-workflows/blob/release-3.4/go.mod#L229

@lvijnck
Copy link

lvijnck commented Feb 6, 2023

Any work arounds known? This only seems to be the case for private repositories (I was able to pull a public one).

@rohankmr414
Copy link
Member

@lvijnck This workaround by Alex might work for you until the fix for this issue is released. You can use your auth token as mentioned here.

@agilgur5 agilgur5 added type/dependencies PRs and issues specific to updating dependencies go Pull requests that update Go dependencies area/artifacts S3/GCP/OSS/Git/HDFS etc labels Jan 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/artifacts S3/GCP/OSS/Git/HDFS etc go Pull requests that update Go dependencies P2 Important. All bugs with >=3 thumbs up that aren’t P0 or P1, plus: Any other bugs deemed important type/bug type/dependencies PRs and issues specific to updating dependencies
Projects
None yet
5 participants