fix: build/lint is broken due to dependencies changes #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We ran into this same error in argo cd it was fixed in this commit argoproj/argo-cd@b0cd653#diff-b8790dc873e80c2f7f63bf198b4da0147787ad8954767b839967d29f65155e2cR70 Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
Signed-off-by: zachaller <zachaller@hotmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
zachaller
changed the title
zachaller
changed the title
Codecov Report
@@ Coverage Diff @@
## master #1958 +/- ##
=======================================
Coverage 82.42% 82.42%
=======================================
Files 119 119
Lines 16913 16913
=======================================
Hits 13940 13940
Misses 2282 2282
Partials 691 691 Continue to review full report at Codecov.
|
|
I actually posted a fix last night for this #1955. I thought about adding a env for go version, but was not sure if the codegen job required a specific version. |
|
@34fathombelow mind if you close your PR I will work on getting this one merged the parameterization of the golang version is a nice value add. |
harikrongali
approved these changes
Apr 5, 2022
jessesuen
approved these changes
Apr 5, 2022
RaviHari
pushed a commit
to RaviHari/argo-rollouts
that referenced
this pull request
Apr 6, 2022
Signed-off-by: zachaller <zachaller@hotmail.com>
This was referenced May 12, 2022
jessesuen
pushed a commit
that referenced
this pull request
May 13, 2022
Signed-off-by: zachaller <zachaller@hotmail.com>
tperdue321
added a commit
to rallyhealth/argo-rollouts
that referenced
this pull request
Aug 30, 2022
* fix: Add pagination to FindLoadBalancerByDNSName (argoproj#1971) * fix: this close issue argoproj#1963 by adding pagination to FindLoadBalancerByDNSName This adds pagination to the FindLoadBalancerByDNSName function this should allow argo rollouts to work with any number of loadbalancers. Signed-off-by: zachaller <zachaller@hotmail.com> * fix: missing lb event (argoproj#2021) * fix: turn missing load balancer log into an event Signed-off-by: zachaller <zachaller@hotmail.com> * consistent naming Signed-off-by: zachaller <zachaller@hotmail.com> * fix: Use actual weight from status field on rollout object (argoproj#1937) fix: Use actual weight from status field on rollout object (argoproj#1937) Signed-off-by: zachaller <zachaller@hotmail.com> * fix: build/lint is broken due to dependencies changes (argoproj#1958) Signed-off-by: zachaller <zachaller@hotmail.com> * following github workflow error prompt to fix Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> * go fmt Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> * make go-mod-vendor Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> * fix path Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> Signed-off-by: zachaller <zachaller@hotmail.com> Signed-off-by: Travis Perdue <travis.perdue@rallyhealth.com> Co-authored-by: Zach Aller <zachaller@users.noreply.github.com> Co-authored-by: Travis Perdue <travis.perdue@rallyhealth.com>
jenciso
pushed a commit
to jenciso/argo-rollouts
that referenced
this pull request
Oct 25, 2022
Signed-off-by: zachaller <zachaller@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We ran into this same issue with argo cd the fix is found here for ArgoCD