feat(argo-cd): Support ability to set .Values.namespaceOverride

[andres-vara]

Resolves #2664

Checklist:

• I have bumped the chart version according to versioning
• I have updated the documentation according to documentation
• I have updated the chart changelog with all the changes that come with this pull request according to changelog.
• Any new values are backwards compatible and/or have sensible default.
• I have signed off all my commits as required by DCO.
• My build is green (troubleshooting builds).

[mkilchhofer]

Hi @andres-vara

Since your PR description misses context or a related issue link:
What is your motivation resp. your use case for this change?

[andres-vara]

Hi @andres-vara

Since your PR description misses context or a related issue link: What is your motivation resp. your use case for this change?

Hi @mkilchhofer
Attached issue to the context.

In my case, I don't have access to .Release.Namespace via the CD tool we use, which is why I believe it's beneficial to have an alternative method of specifying the namespace using the values file.

[pdrastil]

@andres-vara Hi thanks for the contribution but Helm natively supports helm install --namespace <target> flag so IMHO I don't see a need to have override via values.yaml. Why is this needed?

[tico24]

@pdrastil I can answer this one.

If you use a chart as a dependent chart in another, you can't use the --namespace flag to put the dependent chart in a namespace different from the 'main' chart. This is extremely frustrating.

[pdrastil]

@tico24 Question is why would you want to do that. You don't deploy server / repo-server / each controller into separate namespace. In my experienece if you need more than 1 namespace then you should have 2 independent deployments instead of 1 huge umbrella chart as each namespace provides isolation (and if you have Cilium / NetPolicies the namespace override will not work reasonably well anyway).

[tico24]

I wouldn't want to do that. But I would want to deploy (in my case) argo workflows and another application in the same helm chart, but in different namespaces.

I can easily see a requirement to deploy argocd and another application in one helm chart but in different namespaces.

We did discuss this quite a bit in the team slack when the topic first came up. There's strong prescidence out there for doing it, even though it feels hacky (mostly because helm sucks with support for its own dependent chart deployment options).

[andres-vara]

@andres-vara Hi thanks for the contribution but Helm natively supports helm install --namespace <target> flag so IMHO I don't see a need to have override via values.yaml. Why is this needed?

As mentioned earlier, if your company policy requires all helm releases to be in one default namespace, '.Release.Namespace' may not be available for modification. There is no harm in having an additional option to manage the deployment namespace via values

[mkilchhofer]

I think we can accept it, @tico24 found the context we already accepted some months ago:

• feat(argocd-image-updater): Add ability to set .Values.namespaceOverride #2562

[pdrastil]

Ok thanks for sharing context and I'm fine with having extra way of managing things.

[yu-croco]

Hi @andres-vara

I have updated the chart changelog with all the changes that come with this pull request according to changelog.

can you please update (remove old ones and add new one) changelog in Chart.yaml ?
Ref: https://github.com/argoproj/argo-helm/pull/2679/files#diff-16f38cd1a4674cb682ac9f015fbc1c1ff552f024a8f791c16de0de21a1f65771R28-R34