fix: make sure api server informer does not stop after setting change #9842
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexmt
added
the
cherry-pick/2.4
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
alexmt
force-pushed
the
api-restart-informers
branch
from
58fe744
to
8d732d3
Compare
jessesuen
approved these changes
Jun 30, 2022
| @@ -160,6 +160,7 @@ func NewCommand() *cobra.Command { | |||
| stats.StartStatsTicker(10 * time.Minute) | |||
| stats.RegisterHeapDumper("memprofile") | |||
| argocd := server.NewServer(context.Background(), argoCDOpts) | |||
| argocd.Init(context.Background()) | |||
There was a problem hiding this comment.
This is not really your problem, but just noticed we call context.Background() three times in same function and you might consider consolidating to one ctx.
There was a problem hiding this comment.
This problem is fairly pervasive throughout cmd/.
I may look at this a little bit since it's an easy opportunity to get to know the codebase more.
Codecov Report
@@ Coverage Diff @@
## master #9842 +/- ##
=======================================
Coverage 45.86% 45.86%
=======================================
Files 227 227
Lines 26862 26862
=======================================
Hits 12320 12320
Misses 12862 12862
Partials 1680 1680
Continue to review full report at Codecov.
|
rbreeze
approved these changes
Jun 30, 2022
alexmt
added a commit
that referenced
this pull request
Jun 30, 2022
…#9842) Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alexander Matyushentsev AMatyushentsev@gmail.com
PR fixes the bug introduced by #9778. After changing any SSO-related setting the API server returns a stale list of applications/projects. The issue is happening because API server attempts to restart application/app project informers which is not supported. Informer just stops and quietly refuses to start.