log: debug manifest cache #9602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev> fix silly refactor Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Codecov Report
@@ Coverage Diff @@
## master #9602 +/- ##
==========================================
- Coverage 45.82% 45.78% -0.04%
==========================================
Files 222 226 +4
Lines 26376 26713 +337
==========================================
+ Hits 12087 12231 +144
- Misses 12642 12818 +176
- Partials 1647 1664 +17
Continue to review full report at Codecov.
|
leoluz
requested changes
Jun 15, 2022
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
Signed-off-by: Michael Crenshaw <michael@crenshaw.dev>
leoluz
requested changes
Jun 16, 2022
| // LogDebugManifestCacheKeyFields logs all the information included in a manifest cache key. It's intended to be run | ||
| // before every manifest cache operation to help debug cache misses. | ||
| func LogDebugManifestCacheKeyFields(message string, reason string, revision string, appSrc *appv1.ApplicationSource, clusterInfo ClusterRuntimeInfo, namespace string, trackingMethod string, appLabelKey string, appName string) { | ||
| if log.IsLevelEnabled(log.DebugLevel) { |
There was a problem hiding this comment.
I don't think this check is required.
Logrus already checks for this inside the Debug function:
https://github.com/sirupsen/logrus/blob/v1.8.1/logger.go#L195-L201
There was a problem hiding this comment.
It's just a small performance enhancement. Calculating the fields involves some JSON marshaling that I'd rather avoid unless we know we're going to log.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more logging. It was critical to debugging #9601, and I think it might be useful in the future.