chore: Improve appcontroller logs further - Closes [#18113] #18174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add application fully qualified name as a logrus field to several places that were missing it. Remove appNamespace field and replace application name with a fully qualified name in a few places for consistency. Add app project to the log fields. Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
andrii-korotkov-verkada
force-pushed
the
18113-app-name-in-appcontroller-logs
branch
from
3e55929
to
40b3ebd
Compare
…ied name, add a common function for app log entry - Closes[argoproj#18113] Signed-off-by: Andrii Korotkov <andrii.korotkov@verkada.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standardize a way application fields are added to log entries and add them in a few missing places. That'd be helpful to filter all logs related to a given application and have a consistent set of fields. "application" would refer to just the name, not the qualified name, for consistency with audit logger and since "app-namespace" field would also be available.
Checklist: