Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: replace image to one which includes ca-certificates #18068

Merged
merged 4 commits into from May 10, 2024

Conversation

raweber42
Copy link
Contributor

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates? Yes
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged. NOT NEEDED
  • My build is green (troubleshooting builds). NOT NEEDED
  • My new feature complies with the feature status guidelines. NOT NEEDED
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

This PR improves the example given for installing CMP plugins in the documentation. The current image (busybox) does not include ca-certificates, which made the installation fail in my case. This will avoid users from having to debug on a very deep level as I had to. I am open for other image suggestions, of course!
Closes [ISSUE #17885]

Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com>
Signed-off-by: raweber <99535319+raweber42@users.noreply.github.com>
@raweber42 raweber42 marked this pull request as ready for review May 3, 2024 14:03
@raweber42 raweber42 requested review from a team as code owners May 3, 2024 14:03
@raweber42
Copy link
Contributor Author

It's my first PR of this kind, feel free to give me some tips on how to improve!

Co-authored-by: Dan Garfield <dan@codefresh.io>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
Signed-off-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
@crenshaw-dev crenshaw-dev enabled auto-merge (squash) May 10, 2024 13:22
@crenshaw-dev crenshaw-dev merged commit 653fc8d into argoproj:master May 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants