chore: Return the client without performing a matchRepository when the application configures the plugin by name #18053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the application'plugin be configured by its name Signed-off-by: Javier Solana <javier.solana@cabify.com>
crenshaw-dev
requested changes
May 8, 2024
| @@ -165,7 +165,12 @@ func cmpSupports(ctx context.Context, pluginSockFilePath, appPath, repoPath, fil | |||
| return nil, nil, false | |||
| } | |||
|
|
|||
| isSupported, isDiscoveryEnabled, err := matchRepositoryCMP(ctx, appPath, repoPath, cmpClient, env, tarExcludedGlobs) | |||
| // if plugin name is specified, lets return the client directly | |||
| if namedPlugin { | |||
There was a problem hiding this comment.
I think we still only want to do this if discovery is not enabled, since the CMP author might be using discovery as a sort of safety or even security mechanism.
We probably need a pre-flight request to get isDiscoveryEnabled without sending the whole repo. That's a somewhat more involved change, since it'll introduce a new API endpoint.
There was a problem hiding this comment.
Make a lot of sense, let me update the MR
Thanks a lot for your feedback!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17948
Modify the behavior during
DetectConfigManagementPluginto avoid transferring the entire repository to cmp-server when the application configures the plugin by name avoiding performance issues described hereChecklist: