Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add soft documentation for ignoreMissingValueFiles #17996

Conversation

VannTen
Copy link
Contributor

@VannTen VannTen commented Apr 26, 2024

The Helm source has the ability to ignore missing values files since
99d1dca (feat: added a new Helm option ignoreMissingValueFiles,
2022-01-03).
This is however not obvious from reading the user guide on Helm.

Document the parameters along with a reference to the use case which
motivated it.

This is a documentation followup of #8003

Should be cherry-picked into: #8003 is merged since v2.3.0 (git tag --contains 99d1dca), so:

  • v2.3
  • v2.4
  • v2.5
  • v2.6
  • v2.7
  • v2.8
  • v2.9
  • v2.10
  • v2.11

But I guess some of them are out of support ^

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I have signed off all my commits as required by DCO
  • My build is green (troubleshooting builds).
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@VannTen VannTen requested review from a team as code owners April 26, 2024 15:50
The Helm source has the ability to ignore missing values files since
99d1dca (feat: added a new Helm option ignoreMissingValueFiles,
2022-01-03).
This is however not obvious from reading the user guide on Helm.

Document the parameters along with a reference to the use case which
motivated it.

Signed-off-by: Max Gautier <mg@max.gautier.name>
@VannTen VannTen force-pushed the docs/helm_ignore_missing_values_files branch from 5a1a1bf to 1f1999a Compare April 26, 2024 15:52
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL - thanks!

@todaywasawesome todaywasawesome merged commit b738f1f into argoproj:master May 1, 2024
23 checks passed
@todaywasawesome
Copy link
Contributor

@VannTen Generally we only cherry-pick bug/security fixes for n-2 versions so I wouldn't cherry-pick this back.

@VannTen
Copy link
Contributor Author

VannTen commented May 2, 2024 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants