Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(health): Implement k8s.mariadb.com CRD health checks #17995

Merged

Conversation

sennerholm
Copy link
Contributor

@sennerholm sennerholm commented Apr 26, 2024

Health checks for k8s.mariadb.com (https://github.com/mariadb-operator/mariadb-operator) objects, the new name of the mariadb.mmontes.io objects. The main MariaDB healtcheck is also the same.

I doesn't have added "Healthy" testdata and some none-healthy cases, and is asking the users in slack for more samples on "Non Healthy" states that I will add in the future if I get some.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Adding Backup, SqlJobs, Grant, Database and User

Signed-off-by: Mikael Sennerholm <mikael@sennerholm.net>
@sennerholm sennerholm requested a review from a team as a code owner April 26, 2024 15:42
@sennerholm sennerholm changed the title Implement k8s.mariadb.com CRD health checks feat(health) Implement k8s.mariadb.com CRD health checks Apr 26, 2024
@sennerholm sennerholm changed the title feat(health) Implement k8s.mariadb.com CRD health checks feat(health): Implement k8s.mariadb.com CRD health checks Apr 26, 2024
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pasha-codefresh pasha-codefresh merged commit 440fbac into argoproj:master May 8, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants