Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: BanzaiCloud KafkaCluster healthcheck to return Progressing during rolling update #17994

Merged
merged 4 commits into from May 11, 2024

Conversation

musubi7726
Copy link
Contributor

@musubi7726 musubi7726 commented Apr 26, 2024

Updates the Lua HealthCheck for kafka.banzaicloud.io/KafkaCluster. Previously, when syncing a KafkaCluster, it would go into "Degraded" state when the cluster is performing a rolling upgrade. This update sets the status to "Progressing" when the KafkaCluster state is "ClusterRollingUpgrading", regardless of the brokers' status (ConfigInSync/ConfigOutOfSync)

Fixes [#17993]

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@musubi7726 musubi7726 requested a review from a team as a code owner April 26, 2024 15:18
@musubi7726 musubi7726 changed the title Update ClusterRollingUpgrading state to always be Progressing fix - Update ClusterRollingUpgrading state to always be Progressing Apr 26, 2024
@musubi7726 musubi7726 changed the title fix - Update ClusterRollingUpgrading state to always be Progressing fix: BanzaiCloud KafkaCluster healthcheck to return Progressing during rolling update Apr 26, 2024
…e regardless of broker status

Signed-off-by: Ha Van <musubi7726@gmail.com>
Signed-off-by: Ha Van <musubi7726@gmail.com>
Copy link
Contributor

@todaywasawesome todaywasawesome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@todaywasawesome todaywasawesome enabled auto-merge (squash) May 1, 2024 14:15
@musubi7726
Copy link
Contributor Author

Hi @alexmt @christianh814 @34fathombelow - would appreciate if you can review this proposal. Thank you!

@todaywasawesome todaywasawesome merged commit f4fd97d into argoproj:master May 11, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants