New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add note on repo cache for git generator #17980
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Roland Kool <roland@erca.nl)
fd54ab9
to
8de858d
Compare
|
||
## Repository caching | ||
|
||
Files or directories that are added to or removed from the Git repository are only picked up by the ApplicationSet controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Files or directories that are added to or removed from the Git repository are only picked up by the ApplicationSet controller | |
Files or directories that are added to or removed from the git repository are only picked up by the ApplicationSet controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rolandkool I don't think this is correct. By default Argo CD checks for changes to the repo every 3 minutes, if there are no changes to the repo the cache is still invalidated after 24 hours. So for example, if you have a helm chart that generates a random value, that will be picked up every 24 hours but because no files change, not before.
The scenario you've laid out the files are changing and are not being picked up.
@todaywasawesome I'm using a pattern similar to what is described here: https://argo-cd.readthedocs.io/en/stable/operator-manual/applicationset/Generators-Git/#git-generator-files When I add a new directory with a file similar to the |
@rolandkool would you mind sharing what version Argo CD you're using and what git provider? |
I tested this with 2.10.7 iirc and the git provider is our internal gitlab instance. |
## Repository caching | ||
|
||
Files or directories that are added to or removed from the Git repository are only picked up by the ApplicationSet controller |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem like the desired behavior. The AppSet controller should be monitoring for new SHAs on the target revision and pulling new info from repo-server when a new SHA appears.
Checklist: