Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: repo-server should allow not to skip hidden directories #17957

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix: repo-server should allow not to skip hidden directories #17957

wants to merge 9 commits into from

Conversation

BarAshkenazi
Copy link

@BarAshkenazi BarAshkenazi commented Apr 24, 2024 •
edited

Currently, the repo-server skips hidden directories and there is no way to control it. the PR adds an option to include hidden directories.

Fixes #17915

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@BarAshkenazi BarAshkenazi changed the title Update repository.go Fix skipping hidden directories in repo-server Apr 25, 2024
@BarAshkenazi BarAshkenazi changed the title Fix skipping hidden directories in repo-server fix skipping hidden directories in repo-server Apr 25, 2024
@BarAshkenazi BarAshkenazi changed the title fix skipping hidden directories in repo-server fix: should not skip hidden directories in repo-server Apr 25, 2024
@BarAshkenazi BarAshkenazi changed the title fix: should not skip hidden directories in repo-server fix: repo-server should not skip hidden directories Apr 25, 2024
@BarAshkenazi BarAshkenazi mentioned this pull request Apr 25, 2024
Open
3 tasks
crenshaw-dev
crenshaw-dev requested changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing this could be problematic for some users.

I'd recommend making global exclusions configurable via a glob pattern and defaulting to .*.

@BarAshkenazi
Copy link
Author

I was thinking of adding a new flag ARGOCD_REPO_SERVER_INCLUDE_HIDDEN_DIRECTORIES that defaults to false to preserve the current behavior.
Do you think it should be enough or is it essential to add an exclusion pattern as you’ve suggested?

BarAshkenazi and others added 8 commits April 29, 2024 23:52
@BarAshkenazi
Update repository.go
1be3f89 
Signed-off-by: BarAshkenazi <barashkenazi2@gmail.com>
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
support hidden directories in repo server
abb8aff 
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
support hidden directories in repo server
bf0575d 
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
add dir exclusion pattern
164fc80 
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
support hidden directories
0ba4fc5 
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
support hidden directories in repo server
1492a49 
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
support hidden directories in repo server
d780b38 
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
support hidden directories in repo server
6136f05 
Signed-off-by: Bar <bar.ashkenazi@appsflyer.com>
@BarAshkenazi BarAshkenazi changed the title fix: repo-server should not skip hidden directories fix: repo-server should allow not to skip hidden directories Apr 29, 2024
@BarAshkenazi BarAshkenazi marked this pull request as ready for review April 29, 2024 21:17
@BarAshkenazi BarAshkenazi requested review from a team as code owners April 29, 2024 21:17
@BarAshkenazi
Copy link
Author

I've made the changes so it will not interrupt the current behavior as we've discussed using the ARGOCD_REPO_SERVER_INCLUDE_HIDDEN_DIRECTORIES option that defaults to false.
Waiting for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev Awaiting requested review from crenshaw-dev

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ArgoCD AppSet does not recognize hidden directories that start with a dot
2 participants
@BarAshkenazi @crenshaw-dev