Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): fix app sync --local for apps in non-default app namespaces #17944

Conversation

lauren-hinge
Copy link

@lauren-hinge lauren-hinge commented Apr 24, 2024

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

This is mostly to demo the logic that is missing from within the GenerateManifests call. The request itself does not take an appNamespace, and the server side doesn't handle it either.

A better solution would add the namespace to the request and repo-server handling, but I am not familiar enough with the code here to make those changes. (I also have not tracked down how the actual app server knows how to create the annotation properly).

But, as shown here, it is solveable on the client side, if this is somehow preferred!

Replication steps:

  • app in a non-argocd namespace
  • local chart it is pointing to
  • argocd app sync --local <your path>
  • see a SharedResourceWarning, produced by your local sync having sent manifests without the app namespace in the tracking annotation

@lauren-hinge
Copy link
Author

lauren-hinge commented Apr 24, 2024

just a demo while verifying #17945, closing this assuming it's better fixed on the server side

(it does fix it though! 😁)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant