fix(cli): fix app sync --local
for apps in non-default app namespaces
#17944
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
This is mostly to demo the logic that is missing from within the GenerateManifests call. The request itself does not take an appNamespace, and the server side doesn't handle it either.
A better solution would add the namespace to the request and repo-server handling, but I am not familiar enough with the code here to make those changes. (I also have not tracked down how the actual app server knows how to create the annotation properly).
But, as shown here, it is solveable on the client side, if this is somehow preferred!
Replication steps:
argocd
namespaceargocd app sync --local <your path>
SharedResourceWarning
, produced by your local sync having sent manifests without the app namespace in the tracking annotation