feat: Support alias for helm repo in application source #17840
+870
−209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenGuidou
changed the title
OpenGuidou
force-pushed
the
helmalias
branch
2 times, most recently
from
69248b8
to
ddd2d8a
Compare
|
Look good to me. I will take one last look when tests are fixed, For the e2e you need to change the name of your tests. They are used to build the helm release name. It exceeds the 53 chars. Another solution would be to allow to set the release name but this represents more code |
OpenGuidou
force-pushed
the
helmalias
branch
2 times, most recently
from
d4161d7
to
5c57790
Compare
OpenGuidou
changed the title
speedfl
reviewed
Apr 18, 2024
speedfl
reviewed
Apr 18, 2024
speedfl
reviewed
Apr 18, 2024
speedfl
reviewed
Apr 18, 2024
OpenGuidou
force-pushed
the
helmalias
branch
2 times, most recently
from
9565e8e
to
09b3ed6
Compare
|
Would need a code owner approval |
|
@OpenGuidou there are some conflicts now which needs to be resolved |
Signed-off-by: Guillaume Doussin <guillaume.doussin@gmail.com>
@blakepettersson Done now ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17621
In terms of user experience, reusing the name we've defined in the repositories (and most probably shorter than the URL) would be better.
I'm proposing here to reuse the helm alias syntax.
It also allows to have a single Application definition that can be reused in different environments (different repoURL/authentication, under the same repo name) if using separated repo and ArgoCD instances.
Checklist: