Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: document helm fileParameters / helm-set-file #17822

Merged
merged 1 commit into from Apr 25, 2024
Merged

docs: document helm fileParameters / helm-set-file #17822

merged 1 commit into from Apr 25, 2024

Conversation

cardoe
Copy link
Contributor

@cardoe cardoe commented Apr 12, 2024 •
edited

Added documentation for fileParameters in a helm source Application or the --helm-set-file cli option from #2751. Added a note about #13220 so users are aware. #17941 aims to remove this limitation so the warning will be adjusted to mention the version that lands that support.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@cardoe cardoe requested review from a team as code owners April 12, 2024 21:22
@cardoe
Copy link
Contributor Author

cardoe commented Apr 12, 2024

It seemed like the documentation got missed in the original PR so this adds it. Should be possible to back port this to stable releases.

cardoe added a commit to cardoe/argo-cd that referenced this pull request Apr 23, 2024
@cardoe
feat: implement source refs for helm set-file
787bec9 
In multi-source applications helm values files can come from other repos
if you use the ref syntax but it is not possible for the --set-file
param to take files from other repos via the ref syntax. This extends
the behavior to cover set-file parameters as well as the values files.
fixes argoproj#13220, refs argoproj#17822

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
@cardoe cardoe mentioned this pull request Apr 23, 2024
Open
14 tasks
cardoe added a commit to cardoe/argo-cd that referenced this pull request Apr 23, 2024
@cardoe
feat: implement source refs for helm set-file
a190562 
In multi-source applications helm values files can come from other repos
if you use the ref syntax but it is not possible for the --set-file
param to take files from other repos via the ref syntax. This extends
the behavior to cover set-file parameters as well as the values files.
fixes argoproj#13220, refs argoproj#17822

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
@cardoe
Copy link
Contributor Author

cardoe commented Apr 25, 2024

Rebased this PR and updated the message to reference #17941 as the PR that implements the feature.

crenshaw-dev
crenshaw-dev requested changes Apr 25, 2024
View reviewed changes
docs/user-guide/helm.md Outdated Show resolved Hide resolved
docs/user-guide/helm.md Outdated Show resolved Hide resolved
@cardoe
docs: document helm fileParameters / helm-set-file
eb5c364 
Added documentation for fileParameters in a helm source Application or
the --helm-set-file cli option from argoproj#2751. Added a note about argoproj#13220 so
users are aware. argoproj#17941 aims to remove this limitation so the warning
will be adjusted to mention the version that lands that support.

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
@cardoe
Copy link
Contributor Author

cardoe commented Apr 25, 2024

Thank you for the feedback. I've applied your changes.

crenshaw-dev
crenshaw-dev approved these changes Apr 25, 2024
View reviewed changes
Copy link
Collaborator

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@crenshaw-dev crenshaw-dev merged commit 0f11dfb into argoproj:master Apr 25, 2024
23 checks passed
@cardoe cardoe deleted the helm-set-file-doc branch April 25, 2024 15:14
cardoe added a commit to cardoe/argo-cd that referenced this pull request Apr 27, 2024
@cardoe
feat: implement source refs for helm set-file
383591f 
In multi-source applications helm values files can come from other repos
if you use the ref syntax but it is not possible for the --set-file
param to take files from other repos via the ref syntax. This extends
the behavior to cover set-file parameters as well as the values files.
fixes argoproj#13220, refs argoproj#17822

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
cardoe added a commit to cardoe/argo-cd that referenced this pull request Apr 27, 2024
@cardoe
feat: implement source refs for helm set-file
e04ede0 
In multi-source applications helm values files can come from other repos
if you use the ref syntax but it is not possible for the --set-file
param to take files from other repos via the ref syntax. This extends
the behavior to cover set-file parameters as well as the values files.
fixes argoproj#13220, refs argoproj#17822

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
cardoe added a commit to cardoe/argo-cd that referenced this pull request May 4, 2024
@cardoe
feat: implement source refs for helm set-file
87e6981 
In multi-source applications helm values files can come from other repos
if you use the ref syntax but it is not possible for the --set-file
param to take files from other repos via the ref syntax. This extends
the behavior to cover set-file parameters as well as the values files.
fixes argoproj#13220, refs argoproj#17822

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
cardoe added a commit to cardoe/argo-cd that referenced this pull request May 4, 2024
@cardoe
feat: implement source refs for helm set-file
837f4df 
In multi-source applications helm values files can come from other repos
if you use the ref syntax but it is not possible for the --set-file
param to take files from other repos via the ref syntax. This extends
the behavior to cover set-file parameters as well as the values files.
fixes argoproj#13220, refs argoproj#17822

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
cardoe added a commit to cardoe/argo-cd that referenced this pull request May 7, 2024
@cardoe
feat: implement source refs for helm set-file
13a7943 
In multi-source applications helm values files can come from other repos
if you use the ref syntax but it is not possible for the --set-file
param to take files from other repos via the ref syntax. This extends
the behavior to cover set-file parameters as well as the values files.
fixes argoproj#13220, refs argoproj#17822

Signed-off-by: Doug Goldstein <cardoe@cardoe.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cardoe @crenshaw-dev