New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Provide Edit support in Sources tab for multi-source app (#17588) #17589
Closed
keithchong
wants to merge
61
commits into
argoproj:master
from
keithchong:17106-MultiSourceApps-EditSupport
Closed
feat: Provide Edit support in Sources tab for multi-source app (#17588) #17589
keithchong
wants to merge
61
commits into
argoproj:master
from
keithchong:17106-MultiSourceApps-EditSupport
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithchong
force-pushed
the
17106-MultiSourceApps-EditSupport
branch
from
March 22, 2024 01:56
11260d0
to
ca36fa4
Compare
…roj#17588) Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong
force-pushed
the
17106-MultiSourceApps-EditSupport
branch
from
March 26, 2024 20:04
ca36fa4
to
422c6f6
Compare
Signed-off-by: danqixu <yzxudanqi@gmail.com>
Signed-off-by: treble-snake <treble.snake@gmail.com>
Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com>
…rgoproj#17541) Bumps [follow-redirects](https://github.com/follow-redirects/follow-redirects) from 1.15.5 to 1.15.6. - [Release notes](https://github.com/follow-redirects/follow-redirects/releases) - [Commits](follow-redirects/follow-redirects@v1.15.5...v1.15.6) --- updated-dependencies: - dependency-name: follow-redirects dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Add arturia as users Signed-off-by: olivier beyler <beyler_olivier@yahoo.fr>
Bumps [express](https://github.com/expressjs/express) from 4.17.3 to 4.19.2. - [Release notes](https://github.com/expressjs/express/releases) - [Changelog](https://github.com/expressjs/express/blob/master/History.md) - [Commits](expressjs/express@4.17.3...4.19.2) --- updated-dependencies: - dependency-name: express dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* sec: limit helm index max size Signed-off-by: pashakostohrys <pavel@codefresh.io> * sec: limit helm index max size Signed-off-by: pashakostohrys <pavel@codefresh.io> * feat: fix tests and linter Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: Leonardo Luz Almeida <leoluz@users.noreply.github.com>
* Update security.md fix RBAC link Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com> * Update security.md Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com> * Update security.md fix link to application-controller role Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com> * Update security.md Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com> --------- Signed-off-by: Deniz Erdogan <91744937+deer-wmde@users.noreply.github.com>
* docs: added warning for multiple sources Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> * docs: minor spelling Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com> --------- Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
…nd --refresh Flags (argoproj#17613) * add const key value for ComponentRepoServer Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * update NewRepoServerClient() to look for service with ComponentRepoServer labels , if the label exist construct label selector PortForward Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * add comment for the new constants Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * instead of passing nil which leads to nil ptr referance error, pass empty ClusterSharding{} Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * check for operator install repo server name Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * handle empty nil ptr dereference error Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * handle nil prt dereference Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * typo correction Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> * run clidocsgen Signed-off-by: Mangaal <angommeeteimangaal@gmail.com> --------- Signed-off-by: Mangaal <angommeeteimangaal@gmail.com>
…7452) * metadata.annotations: too long Signed-off-by: Surajyadav <harrypotter1108@gmail.com> * added as a default case Signed-off-by: Surajyadav <harrypotter1108@gmail.com> --------- Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
Add Shield.com as one of the users in the USER.md file Signed-off-by: suhas-chikkanna <162577490+suhas-chikkanna@users.noreply.github.com>
Signed-off-by: Kostis (Codefresh) <39800303+kostis-codefresh@users.noreply.github.com>
…proj#17704 (argoproj#17706) * Fix color generation for pod name in logs viewer Signed-off-by: Philipp Trulson <der-eismann@users.noreply.github.com> * Add rebuy to users.md Signed-off-by: Philipp Trulson <der-eismann@users.noreply.github.com> --------- Signed-off-by: Philipp Trulson <der-eismann@users.noreply.github.com>
Signed-off-by: lukasz <lukasz.luszczynski@getyourguide.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
Signed-off-by: Petr Šťastný <petr@stastny.eu>
…mand with `revisions` flag (argoproj#17650) * Add support for multiple source to manifests --revision command Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Update GetManifests to support multiple sources Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * remove testing logs Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * update cli docs Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * add extra validation for diff command Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix lint Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Empty-Commit Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * revert apimachinery version Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * Update docs based on comments Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
…17693) * test: unit test for respectIgnoreDifferences bug Signed-off-by: Jesse Suen <jesse@akuity.io> * test: simplify unit test Signed-off-by: Jesse Suen <jesse@akuity.io> * fix: fix calculating patch for respect ignore diff feature Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Jesse Suen <jesse@akuity.io> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Jesse Suen <jesse@akuity.io>
Bumps library/golang from 1.21.8 to 1.21.9. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps library/golang from 1.21.3 to 1.21.9. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#17664) Bumps library/busybox from `650fd57` to `c3839dd`. --- updated-dependencies: - dependency-name: library/busybox dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
…roj#14242) (argoproj#15636) * squash commits Signed-off-by: Alexy Mantha <alexy@mantha.dev> * Update util/git/client.go Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com> Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix error message Signed-off-by: Alexy Mantha <alexy@mantha.dev> * add git client options Signed-off-by: Alexy Mantha <alexy@mantha.dev> * Update generated code Signed-off-by: Alexy Mantha <alexy@mantha.dev> * run fmt Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix tests Signed-off-by: Alexy Mantha <alexy@mantha.dev> * failed gen Signed-off-by: Alexy Mantha <alexy@mantha.dev> * tweak logs and rename cache Signed-off-by: Alexy Mantha <alexy@mantha.dev> * validate revisions Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix tests Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix tests Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fmt Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix linting Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fixes from review Signed-off-by: Alexy Mantha <alexy@mantha.dev> * generate Signed-off-by: Alexy Mantha <alexy@mantha.dev> * fix Signed-off-by: Alexy Mantha <alexy@mantha.dev> * use log context Signed-off-by: Alexy Mantha <alexy@mantha.dev> --------- Signed-off-by: Alexy Mantha <alexy@mantha.dev> Co-authored-by: Michael Crenshaw <350466+crenshaw-dev@users.noreply.github.com>
…roj#17734) Signed-off-by: ashutosh16 <11219262+ashutosh16@users.noreply.github.com>
Signed-off-by: Anton Hörnquist <anton.hornquist@gmail.com>
… (argoproj#17659) Signed-off-by: Jonathan West <jonwest@redhat.com>
…y fields in swagger (argoproj#17804) * use arrays instead of map to display ApplicationManifetQuery fields in swagger Signed-off-by: ishitasequeira <ishiseq29@gmail.com> * fix equality conditions for souce-position check Signed-off-by: ishitasequeira <ishiseq29@gmail.com> --------- Signed-off-by: ishitasequeira <ishiseq29@gmail.com>
This PR adds Metacore Games to USERS.md. Metacore Games uses ArgoCD as part of our Kubernetes Platform and IDP. Signed-off-by: Juho Syrjänen <juho.syrjanen@metacoregames.com>
* chore: Update USERS.md (argoproj#17683) Add Shield.com as one of the users in the USER.md file Signed-off-by: suhas-chikkanna <162577490+suhas-chikkanna@users.noreply.github.com> sec: validate project before execute action Signed-off-by: pashakostohrys <pavel@codefresh.io> * sec: validate a project before execute an action Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io> Co-authored-by: suhas-chikkanna <162577490+suhas-chikkanna@users.noreply.github.com>
…ackports Release' does not have a Release file. (argoproj#17836) * fix: docker build fails due to "The repository 'http://deb.debian.org/debian buster-backports Release' does not have a Release file." Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix: linter issue Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix codegen issue Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix e2e tests Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix linter Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: pullmerge <watchmessi@outlook.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: CI <ci@argoproj.com> Co-authored-by: CI <ci@argoproj.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
Signed-off-by: jannfis <jann@mistrust.net>
13 tasks
…er (argoproj#17816) Bumps library/node from 21.7.1 to 21.7.3. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…oproj#17815) Bumps library/node from 21.7.1 to 21.7.3. --- updated-dependencies: - dependency-name: library/node dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…j#17794) Bumps library/golang from `7d0dcbe` to `ff6cfbd`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Upgrade to latest stable 7.0.x version to fix CVEs: CVE-2023-41056 Signed-off-by: Tais P. Hansen <taishansen@gmail.com> Co-authored-by: Ishita Sequeira <46771830+ishitasequeira@users.noreply.github.com>
…7757) Signed-off-by: Adrian Berger <adria.berger94@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
…7864) * fix: native client mock should be generated with go gen Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix: native client mock should be generated with go gen Signed-off-by: pashakostohrys <pavel@codefresh.io> * fix: native client mock should be generated with go gen Signed-off-by: pashakostohrys <pavel@codefresh.io> * adopt repository_test.go to new helm mock client Signed-off-by: pashakostohrys <pavel@codefresh.io> --------- Signed-off-by: pashakostohrys <pavel@codefresh.io>
Signed-off-by: pashakostohrys <pavel@codefresh.io>
…proj#17274) (argoproj#17275) * feat: Add Sources tab to show all sources of a multi-source app (argoproj#17274) Signed-off-by: Keith Chong <kykchong@redhat.com> * Update ui/src/app/applications/components/resource-details/resource-details.tsx Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com> Signed-off-by: Keith Chong <kykchong@redhat.com> * Remove getAppSources Signed-off-by: Keith Chong <kykchong@redhat.com> * Add address Ishita's comments. Add missing Ref field Signed-off-by: Keith Chong <kykchong@redhat.com> * Use single quotes Signed-off-by: Keith Chong <kykchong@redhat.com> --------- Signed-off-by: Keith Chong <kykchong@redhat.com> Co-authored-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Bumps library/golang from `7d0dcbe` to `81811f8`. --- updated-dependencies: - dependency-name: library/golang dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…rgoproj#17872) Signed-off-by: isihu <62214125+isihu@users.noreply.github.com>
So that log messages are propagated up, this caused issues for me when trying to diagnose an issue linked to issue argoproj#17811. I've just copied the approach used e.g. in `controller/appcontroller.go` when calling `argodiff.NewDiffConfigBuilder`. Sample output before this change: $ argocd --loglevel debug --server argocd-system.dev.aws.uw.systems app diff dev-enablement/dev-enablement ===== apps/Deployment dev-enablement/go-docs ====== 272c272 < cpu: "0" --- > cpu: 0m 275c275 < cpu: "0" --- > cpu: 0m Output with this change: $ argocd --loglevel debug --server argocd-system.dev.aws.uw.systems app diff dev-enablement/dev-enablement INFO[0000] Could not unmarshal to object of type apps/v1, Kind=Deployment: json: unknown field "restartPolicy" INFO[0000] Could not unmarshal to object of type apps/v1, Kind=Deployment: json: unknown field "restartPolicy" ===== apps/Deployment dev-enablement/go-docs ====== 272c272 < cpu: "0" --- > cpu: 0m 275c275 < cpu: "0" --- > cpu: 0m INFO[0000] Could not create new object of type argoproj.io/v1alpha1, Kind=Application: no kind "Application" is registered for version "argoproj.io/v1alpha1" in scheme "pkg/runtime/scheme.go:100" INFO[0000] Could not create new object of type argoproj.io/v1alpha1, Kind=Application: no kind "Application" is registered for version "argoproj.io/v1alpha1" in scheme "pkg/runtime/scheme.go:100" INFO[0000] Could not create new object of type traefik.containo.us/v1alpha1, Kind=IngressRoute: no kind "IngressRoute" is registered for version "traefik.containo.us/v1alpha1" in scheme "pkg/runtime/scheme.go:100" INFO[0000] Could not create new object of type traefik.containo.us/v1alpha1, Kind=IngressRoute: no kind "IngressRoute" is registered for version "traefik.containo.us/v1alpha1" in scheme "pkg/runtime/scheme.go:100" INFO[0000] Could not create new object of type traefik.containo.us/v1alpha1, Kind=IngressRoute: no kind "IngressRoute" is registered for version "traefik.containo.us/v1alpha1" in scheme "pkg/runtime/scheme.go:100" INFO[0000] Could not create new object of type traefik.containo.us/v1alpha1, Kind=IngressRoute: no kind "IngressRoute" is registered for version "traefik.containo.us/v1alpha1" in scheme "pkg/runtime/scheme.go:100" Signed-off-by: Matt Hughes <mhughes@uw.co.uk>
…goproj#17866) * chore: update gitops engine version Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * add: e2e and docs for force sync options Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> * docs: Add warning description of force sync options Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> --------- Signed-off-by: kkk777-7 <kota.kimura0725@gmail.com> Co-authored-by: pasha-codefresh <pavel@codefresh.io>
* remove deprecated default cipher Signed-off-by: Josh Wolf <josh@wolfs.io> * regenerate CLI docs Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> --------- Signed-off-by: Josh Wolf <josh@wolfs.io> Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com> Co-authored-by: Jann Fischer <jann@mistrust.net> Co-authored-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
…roj#17588) Signed-off-by: Keith Chong <kykchong@redhat.com>
Some issue with rebasing. Closing this. Since no comments were added here, it's simpler to just create a new PR here: #17890 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #17588
This PR builds upon #17275
This PR adds/enables the "Edit" button to the Source and Parameter sections of each collapsible panel under the new Sources tab added from #17275.
There are a few noteworthy design points to this:
Testing:
Checklist: