Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): trim-whitespaces in Project editor panel #17379

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

surajyadav1108
Copy link
Contributor

@surajyadav1108 surajyadav1108 commented Mar 2, 2024

resolves #14694
trims whitespaces for input fields on Project UI edit-panel including Source repo, destination, label etc.

trim.mp4

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

Signed-off-by: Surajyadav <harrypotter1108@gmail.com>
@surajyadav1108 surajyadav1108 requested a review from a team as a code owner March 2, 2024 07:50
@surajyadav1108 surajyadav1108 changed the title trim-whitespaces fix(ui): trim-whitespaces Mar 2, 2024
@surajyadav1108 surajyadav1108 changed the title fix(ui): trim-whitespaces fix(ui): trim-whitespaces in Project editor panel Mar 2, 2024
@surajyadav1108
Copy link
Contributor Author

Hey @ishitasequeira
I totally forgot about this. I have added the trim function on the server side now, as suggested. Can you review it in your spare time 😅?

@surajyadav1108 surajyadav1108 changed the title fix(ui): trim-whitespaces in Project editor panel fix(core): trim-whitespaces in Project editor panel Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Project editor UI doesn't strip whitespace from destination server URLs
2 participants