Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support helm repo alias in repoUrl #17621

Open
OpenGuidou opened this issue Mar 25, 2024 · 2 comments · May be fixed by #17840
Open

Support helm repo alias in repoUrl #17621

OpenGuidou opened this issue Mar 25, 2024 · 2 comments · May be fixed by #17840
Labels
enhancement New feature or request

Comments

@OpenGuidou
Copy link

OpenGuidou commented Mar 25, 2024

Summary

Helm repo alias is supported in chart dependency, but we can't reuse it when using a chart as source in an Application.

Motivation

It would be useful to reuse the alias and not have to reuse the URL if already added in the repo list.
We also need to provide the full URL in the project allowed sources, where we could provide a short alias.

Proposal

Support the same patterns in repoURL (when Helm is the source type) as in the helm dependencies:

apiVersion: argoproj.io/v1alpha1
kind: Application
metadata:
  name: sealed-secrets
  namespace: argocd
spec:
  project: default
  source:
    chart: sealed-secrets
    repoURL: "@sealed-secrets" or "alias:sealed-secrets"
    targetRevision: 1.16.1
    helm:
      releaseName: sealed-secrets

Do you think it would make sense ?

If so I can propose a PR.

@OpenGuidou OpenGuidou added the enhancement New feature or request label Mar 25, 2024
@blakepettersson
Copy link
Member

Sounds like a duplicate of #10320. A PR makes sense to me!

@OpenGuidou
Copy link
Author

I'm not sure it's a duplicate as it's used as a dependency in the other issue, not as a source.
But anyway I can propose a PR 😄

@OpenGuidou OpenGuidou linked a pull request Apr 15, 2024 that will close this issue
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants