Skip to content

Commit

Permalink
fix: web terminal due to query parameters name mismatch (#9560)
Browse files Browse the repository at this point in the history
Signed-off-by: Alexander Matyushentsev <AMatyushentsev@gmail.com>
  • Loading branch information
alexmt committed Jun 1, 2022
1 parent 61f48d5 commit dee550a
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions server/application/terminal.go
Expand Up @@ -94,8 +94,8 @@ func (s *terminalHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {

podName := q.Get("pod")
container := q.Get("container")
app := q.Get("app")
project := q.Get("project")
app := q.Get("appName")
project := q.Get("projectName")
namespace := q.Get("namespace")

if podName == "" || container == "" || app == "" || project == "" || namespace == "" {
Expand Down Expand Up @@ -123,7 +123,7 @@ func (s *terminalHandler) ServeHTTP(w http.ResponseWriter, r *http.Request) {
http.Error(w, "Namespace name is not valid", http.StatusBadRequest)
return
}
shell := q.Get("shell") // No need to validate. Will only buse used if it's in the allow-list.
shell := q.Get("shell") // No need to validate. Will only buse used if it's in the allow-list.

ctx := r.Context()

Expand Down

0 comments on commit dee550a

Please sign in to comment.