Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add passing yaml dump options to to_yaml #387

Merged
merged 1 commit into from Dec 16, 2022

Conversation

samj1912
Copy link
Collaborator

@samj1912 samj1912 commented Dec 16, 2022

This should allow users to pass in various yaml dump options to customize their yaml output per their wishes.

Fixes #378

pyyaml exposes a sort_keys=false param which can be used. See yaml/pyyaml#110 (comment)

Signed-off-by: Sambhav Kothari <skothari44@bloomberg.net>
Copy link
Collaborator

@flaviuvadan flaviuvadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @samj1912 I will take a look at the coverage issue in another PR as it does not have to do with the contribution here

@flaviuvadan flaviuvadan merged commit 2ba378d into argoproj-labs:main Dec 16, 2022
@samj1912 samj1912 deleted the yaml-dump branch December 16, 2022 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ordering keys in the yaml dump
2 participants