Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

select2 4.0.3 -> 4.0.5 #178

Closed
wants to merge 1 commit into from

Conversation

ewalk153
Copy link

@ewalk153 ewalk153 commented Jan 31, 2018

  • Bump select2 from 4.0.3 to 4.0.5 by running rake update-select2

I've run this locally on a Rails 5.0.x. I've confirmed that the default behavior for autocapitalize=none has changed (per select2/select2#4994) to confirm that this successfully references the new code.

 - Bump select2 from 4.0.3 to 4.0.5
@ewalk153
Copy link
Author

@argerim do you have time to review this PR? Anything I can do to help?

Copy link

@warrenguy warrenguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to bump version number in lib/select2-rails/version.rb also

@mabdelfattah
Copy link

I made a separate fork with a separate gem that includes latest select2 versions and latest bootstrap theme version too. You can find it here if you are interested: https://rubygems.org/gems/select2-rails-latest

@ewalk153
Copy link
Author

@mabdelfattah closing this PR as the project seems to be unmaintained. Maybe you can get the upstream select2 project to point to your fork.

@ewalk153 ewalk153 closed this Apr 23, 2018
@mabdelfattah
Copy link

@ewalk153 how this could be done?

@ewalk153
Copy link
Author

Open an issue in the select2 project:
https://github.com/select2/select2/issues To get things started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants