Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use eToken for signing #2599

Merged
merged 3 commits into from May 16, 2024
Merged

use eToken for signing #2599

merged 3 commits into from May 16, 2024

Conversation

umbynos
Copy link
Contributor

@umbynos umbynos commented May 9, 2024

Please check if the PR fulfills these requirements

See how to contribute

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • configuration.schema.json updated if new parameters are added.

What kind of change does this PR introduce?

Infra change

What is the current behavior?

The certificate used to sign windows binaries is expiring, and the provider no longer ships a digital one.

What is the new behavior?

We have setup a local runner used to sign.

Does this PR introduce a breaking change, and is titled accordingly?

no

Other information

TODO:

  • Remove INSTALLER_CERT_WINDOWS_PFX and use INSTALLER_CERT_WINDOWS_CER
  • Replace INSTALLER_CERT_WINDOWS_PASSWORD
  • Add INSTALLER_CERT_WINDOWS_CONTAINER

@umbynos umbynos requested a review from Xayton May 9, 2024 12:59
@umbynos umbynos self-assigned this May 9, 2024
@umbynos umbynos added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels May 9, 2024
Copy link

codecov bot commented May 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.13%. Comparing base (8b78c05) to head (53fa85f).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2599      +/-   ##
==========================================
+ Coverage   70.11%   70.13%   +0.01%     
==========================================
  Files         222      222              
  Lines       21124    21124              
==========================================
+ Hits        14812    14816       +4     
+ Misses       5135     5132       -3     
+ Partials     1177     1176       -1     
Flag Coverage Δ
unit 70.13% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@alessio-perugini alessio-perugini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, 🙌

Copy link

@Xayton Xayton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@umbynos umbynos merged commit 63a48c5 into master May 16, 2024
115 checks passed
@umbynos umbynos deleted the sign-locally branch May 16, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants