fix(tabs): adjust the watch execution order of tabs and activeIndex #1936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
flsion
reviewed
Dec 30, 2022
| activeKey={computedActiveKey.value} | ||
| activeIndex={activeIndex.value} | ||
| tabs={sortedTabs.value} |
There was a problem hiding this comment.
仅修改 tabs 的顺序不能解决这个问题吧，这里不会影响 TabsNav 内部计算初始显示位置的时机
There was a problem hiding this comment.
原本是打算用 flush: 'sync' 或者immediate:true来确保tabs的watch比activeIndex的watch先执行，在用vite写的demo的时候发现切换顺序也能让tabs的watch先执行。不过webpack中却不是这样的。保证watch的顺序还是得用flush: 'sync' 或者immediate:true
There was a problem hiding this comment.
不过虽然可以让tabs的watch先执行，但是在activeIndex中的watch获取wrapperLength.value 和 maxOffset.value不正确的值
There was a problem hiding this comment.
activeIndex 中watch的nextTick我直接换成了setTimeout，也可以watch([tabs,activeIndex]判断tabs发生修改才用setTimeout。
There was a problem hiding this comment.
另外就是直接设置activeIndex 为最后一项的时候，next按钮并未置灰 。offset.value值比maxOffset.value小了几像素
Saber-Kurama
force-pushed
the
fix-tabs
branch
from
a487fa6
to
94bf2c1
Compare
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes
Background and context
Solution
How is the change tested?
Changelog
Checklist:
npm run test)featurebranch and othersshould be submitted to
mainbranch)Other information