Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spreadsheet builder model and specs #3204

Merged

Conversation

stitching-coder
Copy link
Contributor

@stitching-coder stitching-coder commented May 19, 2024

Description

Add spreadsheet builder model for bulk update

note: This feature was originally developed by Hudson Molonglo for The New School as a plugin. It has been adapted for the core code of ArchivesSpace.

How Has This Been Tested?

Testing with unit tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have read the CONTRIBUTING document.
  • I have authority to submit this code.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@stitching-coder stitching-coder changed the title Add spreadsheet builder Add spreadsheet builder model and specs May 19, 2024
@stitching-coder stitching-coder marked this pull request as ready for review May 20, 2024 13:30
@stitching-coder
Copy link
Contributor Author

@thimios I am continuing to work on unit tests.

@thimios thimios marked this pull request as draft May 22, 2024 18:24
@thimios
Copy link
Collaborator

thimios commented May 22, 2024

@stitching-coder I have converted this to a draft PR. Go ahead and click "Ready for review" once you are done with specs and I will review asap.

@stitching-coder stitching-coder marked this pull request as ready for review May 24, 2024 02:11
@stitching-coder stitching-coder marked this pull request as draft May 24, 2024 11:32
@stitching-coder stitching-coder marked this pull request as ready for review May 29, 2024 00:57
@thimios
Copy link
Collaborator

thimios commented May 29, 2024

@stitching-coder looks great, could you squash all commits into one and merge it?

@stitching-coder
Copy link
Contributor Author

@thimios I do not have permissions to merge it.

@brianzelip brianzelip merged commit 604db01 into archivesspace:master May 29, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants