Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ANW-1977: Fix Staff tooltip bugs #3193

Merged
merged 1 commit into from
May 22, 2024
Merged

Conversation

brianzelip
Copy link
Collaborator

@brianzelip brianzelip commented May 2, 2024

This PR:

  • Repositions the tooltip generated via link_to_help(), and hacks around tightly coupled surbform heading markup and form behavior
  • Fixes the tooltip generated via wrap_with_tooltip()
  • Brings spacing around some .form-actions button groups inline with the rest of the app

ANW-1977

Before

ANW-1977-bad-tooltips

After

ANW-1977-good-tooltip

@brianzelip brianzelip marked this pull request as ready for review May 2, 2024 17:41
@brianzelip
Copy link
Collaborator Author

Merging of this PR is awaiting the rebasing into master of the main Softserv branch for ANW-1727, then this should be merged into master.

@brianzelip brianzelip force-pushed the ANW-1727-softserv-upgrades-final-build branch from a9bd143 to 3ef0292 Compare May 9, 2024 15:42
Base automatically changed from ANW-1727-softserv-upgrades-final-build to master May 20, 2024 21:00
Reposition the tooltip generated via link_to_help(),
and hack around tightly coupled surbform heading markup.
Fix the tooltip generated via wrap_with_tooltip().
Make consistent some .form-actions button groups spacing.
@thimios thimios closed this May 22, 2024
@thimios thimios reopened this May 22, 2024
@thimios thimios merged commit 1c003fb into master May 22, 2024
29 checks passed
@thimios thimios deleted the ANW-1977-popovers-and-tooltips branch May 22, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants