ANW-1843: add toggle to exclude <unitid> containing ASpace URI from EAD #3188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
current default is to not pass any options including this newly added one, which is breaking the OAI unit tests
thimios
requested changes
May 1, 2024
| @@ -209,9 +209,11 @@ def archival_object(index) | |||
|
|
|||
| as_test_user("admin", true) do | |||
| load_export_fixtures | |||
| @doc = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@resource.id}.xml?include_unpublished=true&include_daos=true&ead3=true") | |||
There was a problem hiding this comment.
I think we should keep a test that checks that the default behavior (the one that is currently happening on master) also continues to happen on these changes if no include_uri_unitids parameter is present in the request.
| @@ -1377,7 +1383,7 @@ def description_content(obj) | |||
| describe "Test unpublished record EAD exports" do | |||
|
|
|||
| def get_xml_doc(include_unpublished = false) | |||
| doc_for_unpublished_resource = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@unpublished_resource_jsonmodel.id}.xml?include_unpublished=#{include_unpublished}&include_daos=true&ead3=true", true) | |||
| doc_for_unpublished_resource = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@unpublished_resource_jsonmodel.id}.xml?include_unpublished=#{include_unpublished}&include_daos=true&include_uri_unitids=true&ead3=true", true) | |||
There was a problem hiding this comment.
Same thing here, we should ensure that the default behavior happens if no include_uri_unitids param is given.
| @@ -1483,7 +1489,7 @@ def get_xml_doc(include_unpublished = false) | |||
| def get_xml_doc | |||
| as_test_user("admin") do | |||
| DB.open(true) do | |||
| doc_for_resource = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@resource_jsonmodel.id}.xml?include_unpublished=true&include_daos=true", true) | |||
| doc_for_resource = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@resource_jsonmodel.id}.xml?include_unpublished=true&include_daos=true&include_uri_unitids=true", true) | |||
There was a problem hiding this comment.
same as above. We should check that the default behavior is happening both
- if
include_uri_uinitids=trueis present - and if no
include_uri_unitidsparam is present
| @@ -1579,7 +1585,7 @@ def get_xml_doc | |||
| def get_xml_doc | |||
| as_test_user("admin") do | |||
| DB.open(true) do | |||
| doc_for_resource = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@resource.id}.xml?include_unpublished=true&include_daos=true&ead3=true", true) | |||
| doc_for_resource = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@resource.id}.xml?include_unpublished=true&include_daos=true&include_uri_unitids=true&ead3=true", true) | |||
There was a problem hiding this comment.
same as above. We should check that the default behavior is happening both
- if
include_uri_uinitids=trueis present - and if no
include_uri_unitidsparam is present
| @doc_unpub = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@resource.id}.xml?include_daos=true") | ||
| @doc = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@resource.id}.xml?include_unpublished=true&include_daos=true&include_uri_unitids=true") | ||
| @doc_unpub = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@resource.id}.xml?include_daos=true&include_uri_unitids=true") | ||
| @doc_no_uri = get_xml("/repositories/#{$repo_id}/resource_descriptions/#{@resource.id}.xml?include_daos=true&include_uri_unitids=false") | ||
|
|
There was a problem hiding this comment.
same comment. We should also add the case when no include_uri_unitids param is present
|
Implemented here: #3228 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add toggle to exclude containing ASpace URI from EAD
Related JIRA Ticket or GitHub Issue
https://archivesspace.atlassian.net/browse/ANW-1843
How Has This Been Tested?
manual and unit testing
Screenshots (if appropriate):
Types of changes
Checklist: